Change appcheck activate() to use provider pattern #4902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c9c364d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment has been minimized.
This comment has been minimized.
hsubox76
force-pushed
the
ch-appcheck-provider
branch
from
eb6fba9 to
d1cc28c
Compare
Changeset File Check ✅
|
hsubox76
commented
Jul 8, 2021
Feiyang1
suggested changes
Jul 13, 2021
Feiyang1
reviewed
Jul 26, 2021
Feiyang1
suggested changes
Jul 28, 2021
kevinthecheung
approved these changes
Jul 28, 2021
Feiyang1
suggested changes
Jul 30, 2021
Feiyang1
approved these changes
Jul 30, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create provider classes that users can use in
activate(). To avoid breaking changes,activatestill takes a string site key or our previous custom provider pattern, which is any object with agetTokenproperty.I also changed
addTokenListenerto check for existing tokens in both memory and storage because otherwise it will only check storage ifgetToken()is called, which only happens if the refresher starts, which only happens if automatic token refresh is enabled. I don't think fetching a token from local storage should be gated on that.Note: API changes should also be propagated to v9 compat after this.
Edit: For docs review - only need to review
packages/firebase/index.d.ts