Skip to content

Add cached token changes to v9 appcheck #5226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Conversation

hsubox76
Copy link
Contributor

Copy part of the v8 app check PR #4902 that involves checking for token in storage during initialization. (The rest of 4902 was already in v9.)

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2021

⚠️ No Changeset found

Latest commit: 113086a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 30, 2021

Binary Size Report

Affected SDKs

No changes between base commit (8599d91) and head commit (aa48dad).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 30, 2021

Size Analysis Report

Affected Products

  • @firebase/app-check-exp

    • CustomProvider

      Size Table

      TypeBase (8599d91)Head (aa48dad)Diff
      size
      9.83 kB
      9.77 kB
      -64 B (-0.7%)
      size-with-ext-deps
      19.7 kB
      19.6 kB
      -64 B (-0.3%)

      Dependency Table

      TypeBase (8599d91)Head (aa48dad)Diff
      functions

      33 dependencies

      addTokenListener
      computeKey
      createTokenRefresher
      ensureActivated
      exchangeToken
      factory
      formatDummyToken
      getDBPromise
      getDebugState
      getDebugToken
      getExchangeDebugTokenRequest
      getState
      getToken$2
      initializeDebugMode
      internalFactory
      isDebugMode
      isValid
      makeDummyTokenResult
      notifyTokenListeners
      read
      readDebugTokenFromIndexedDB
      readOrCreateDebugTokenFromStorage
      readTokenFromIndexedDB
      readTokenFromStorage
      registerAppCheck
      removeTokenListener
      setState
      sleep
      uuidv4
      write
      writeDebugTokenToIndexedDB
      writeTokenToIndexedDB
      writeTokenToStorage
      

      31 dependencies

      addTokenListener
      computeKey
      createTokenRefresher
      ensureActivated
      exchangeToken
      factory
      formatDummyToken
      getDBPromise
      getDebugState
      getDebugToken
      getExchangeDebugTokenRequest
      getState
      getToken$2
      initializeDebugMode
      internalFactory
      isDebugMode
      isValid
      makeDummyTokenResult
      notifyTokenListeners
      read
      readDebugTokenFromIndexedDB
      readOrCreateDebugTokenFromStorage
      registerAppCheck
      removeTokenListener
      setState
      sleep
      uuidv4
      write
      writeDebugTokenToIndexedDB
      writeTokenToIndexedDB
      writeTokenToStorage
      

      - readTokenFromIndexedDB
      - readTokenFromStorage

    • ReCaptchaV3Provider

      Size Table

      TypeBase (8599d91)Head (aa48dad)Diff
      size
      11.1 kB
      11.1 kB
      -62 B (-0.6%)
      size-with-ext-deps
      20.6 kB
      20.5 kB
      -64 B (-0.3%)

      Dependency Table

      TypeBase (8599d91)Head (aa48dad)Diff
      functions

      39 dependencies

      addTokenListener
      computeKey
      createTokenRefresher
      ensureActivated
      exchangeToken
      factory
      formatDummyToken
      getDBPromise
      getDebugState
      getDebugToken
      getExchangeDebugTokenRequest
      getExchangeRecaptchaTokenRequest
      getRecaptcha
      getState
      getToken$1
      getToken$2
      initialize
      initializeDebugMode
      internalFactory
      isDebugMode
      isValid
      loadReCAPTCHAScript
      makeDummyTokenResult
      notifyTokenListeners
      read
      readDebugTokenFromIndexedDB
      readOrCreateDebugTokenFromStorage
      readTokenFromIndexedDB
      readTokenFromStorage
      registerAppCheck
      removeTokenListener
      renderInvisibleWidget
      setState
      sleep
      uuidv4
      write
      writeDebugTokenToIndexedDB
      writeTokenToIndexedDB
      writeTokenToStorage
      

      37 dependencies

      addTokenListener
      computeKey
      createTokenRefresher
      ensureActivated
      exchangeToken
      factory
      formatDummyToken
      getDBPromise
      getDebugState
      getDebugToken
      getExchangeDebugTokenRequest
      getExchangeRecaptchaTokenRequest
      getRecaptcha
      getState
      getToken$1
      getToken$2
      initialize
      initializeDebugMode
      internalFactory
      isDebugMode
      isValid
      loadReCAPTCHAScript
      makeDummyTokenResult
      notifyTokenListeners
      read
      readDebugTokenFromIndexedDB
      readOrCreateDebugTokenFromStorage
      registerAppCheck
      removeTokenListener
      renderInvisibleWidget
      setState
      sleep
      uuidv4
      write
      writeDebugTokenToIndexedDB
      writeTokenToIndexedDB
      writeTokenToStorage
      

      - readTokenFromIndexedDB
      - readTokenFromStorage

    • getToken

      Size Table

      TypeBase (8599d91)Head (aa48dad)Diff
      size
      9.54 kB
      9.48 kB
      -62 B (-0.6%)
      size-with-ext-deps
      18.9 kB
      18.9 kB
      -64 B (-0.3%)

      Dependency Table

      TypeBase (8599d91)Head (aa48dad)Diff
      functions

      34 dependencies

      addTokenListener
      computeKey
      createTokenRefresher
      ensureActivated
      exchangeToken
      factory
      formatDummyToken
      getDBPromise
      getDebugState
      getDebugToken
      getExchangeDebugTokenRequest
      getState
      getToken
      getToken$2
      initializeDebugMode
      internalFactory
      isDebugMode
      isValid
      makeDummyTokenResult
      notifyTokenListeners
      read
      readDebugTokenFromIndexedDB
      readOrCreateDebugTokenFromStorage
      readTokenFromIndexedDB
      readTokenFromStorage
      registerAppCheck
      removeTokenListener
      setState
      sleep
      uuidv4
      write
      writeDebugTokenToIndexedDB
      writeTokenToIndexedDB
      writeTokenToStorage
      

      32 dependencies

      addTokenListener
      computeKey
      createTokenRefresher
      ensureActivated
      exchangeToken
      factory
      formatDummyToken
      getDBPromise
      getDebugState
      getDebugToken
      getExchangeDebugTokenRequest
      getState
      getToken
      getToken$2
      initializeDebugMode
      internalFactory
      isDebugMode
      isValid
      makeDummyTokenResult
      notifyTokenListeners
      read
      readDebugTokenFromIndexedDB
      readOrCreateDebugTokenFromStorage
      registerAppCheck
      removeTokenListener
      setState
      sleep
      uuidv4
      write
      writeDebugTokenToIndexedDB
      writeTokenToIndexedDB
      writeTokenToStorage
      

      - readTokenFromIndexedDB
      - readTokenFromStorage

    • initializeAppCheck

      Size Table

      TypeBase (8599d91)Head (aa48dad)Diff
      size
      9.96 kB
      10.2 kB
      +241 B (+2.4%)
      size-with-ext-deps
      19.5 kB
      19.8 kB
      +243 B (+1.2%)
    • onTokenChanged

      Size Table

      TypeBase (8599d91)Head (aa48dad)Diff
      size
      9.64 kB
      9.57 kB
      -62 B (-0.6%)
      size-with-ext-deps
      19.0 kB
      19.0 kB
      -64 B (-0.3%)

      Dependency Table

      TypeBase (8599d91)Head (aa48dad)Diff
      functions

      34 dependencies

      addTokenListener
      computeKey
      createTokenRefresher
      ensureActivated
      exchangeToken
      factory
      formatDummyToken
      getDBPromise
      getDebugState
      getDebugToken
      getExchangeDebugTokenRequest
      getState
      getToken$2
      initializeDebugMode
      internalFactory
      isDebugMode
      isValid
      makeDummyTokenResult
      notifyTokenListeners
      onTokenChanged
      read
      readDebugTokenFromIndexedDB
      readOrCreateDebugTokenFromStorage
      readTokenFromIndexedDB
      readTokenFromStorage
      registerAppCheck
      removeTokenListener
      setState
      sleep
      uuidv4
      write
      writeDebugTokenToIndexedDB
      writeTokenToIndexedDB
      writeTokenToStorage
      

      32 dependencies

      addTokenListener
      computeKey
      createTokenRefresher
      ensureActivated
      exchangeToken
      factory
      formatDummyToken
      getDBPromise
      getDebugState
      getDebugToken
      getExchangeDebugTokenRequest
      getState
      getToken$2
      initializeDebugMode
      internalFactory
      isDebugMode
      isValid
      makeDummyTokenResult
      notifyTokenListeners
      onTokenChanged
      read
      readDebugTokenFromIndexedDB
      readOrCreateDebugTokenFromStorage
      registerAppCheck
      removeTokenListener
      setState
      sleep
      uuidv4
      write
      writeDebugTokenToIndexedDB
      writeTokenToIndexedDB
      writeTokenToStorage
      

      - readTokenFromIndexedDB
      - readTokenFromStorage

    • setTokenAutoRefreshEnabled

      Size Table

      TypeBase (8599d91)Head (aa48dad)Diff
      size
      9.67 kB
      9.61 kB
      -62 B (-0.6%)
      size-with-ext-deps
      19.1 kB
      19.0 kB
      -64 B (-0.3%)

      Dependency Table

      TypeBase (8599d91)Head (aa48dad)Diff
      functions

      34 dependencies

      addTokenListener
      computeKey
      createTokenRefresher
      ensureActivated
      exchangeToken
      factory
      formatDummyToken
      getDBPromise
      getDebugState
      getDebugToken
      getExchangeDebugTokenRequest
      getState
      getToken$2
      initializeDebugMode
      internalFactory
      isDebugMode
      isValid
      makeDummyTokenResult
      notifyTokenListeners
      read
      readDebugTokenFromIndexedDB
      readOrCreateDebugTokenFromStorage
      readTokenFromIndexedDB
      readTokenFromStorage
      registerAppCheck
      removeTokenListener
      setState
      setTokenAutoRefreshEnabled
      sleep
      uuidv4
      write
      writeDebugTokenToIndexedDB
      writeTokenToIndexedDB
      writeTokenToStorage
      

      32 dependencies

      addTokenListener
      computeKey
      createTokenRefresher
      ensureActivated
      exchangeToken
      factory
      formatDummyToken
      getDBPromise
      getDebugState
      getDebugToken
      getExchangeDebugTokenRequest
      getState
      getToken$2
      initializeDebugMode
      internalFactory
      isDebugMode
      isValid
      makeDummyTokenResult
      notifyTokenListeners
      read
      readDebugTokenFromIndexedDB
      readOrCreateDebugTokenFromStorage
      registerAppCheck
      removeTokenListener
      setState
      setTokenAutoRefreshEnabled
      sleep
      uuidv4
      write
      writeDebugTokenToIndexedDB
      writeTokenToIndexedDB
      writeTokenToStorage
      

      - readTokenFromIndexedDB
      - readTokenFromStorage

@hsubox76 hsubox76 added this to the v9 GA milestone Aug 11, 2021
@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Aug 12, 2021
@hsubox76 hsubox76 merged commit ab428f6 into master Aug 16, 2021
@hsubox76 hsubox76 deleted the ch-appcheckexp-storage branch August 16, 2021 20:22
@firebase firebase locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants