Skip to content

Change appcheck activate() to use provider pattern #4902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 30, 2021
Merged

Change appcheck activate() to use provider pattern #4902

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
60a7a80
Convert app-check to provider pattern
hsubox76 May 13, 2021
5acfdae
Fix up types
hsubox76 May 13, 2021
d1cc28c
Add providers for app check
hsubox76 Jul 8, 2021
5096312
Add changeset.
hsubox76 Jul 8, 2021
aa1dfef
Update syntax to match other PR
hsubox76 Jul 9, 2021
71e70fe
Address some PR comments
hsubox76 Jul 14, 2021
cafe993
Use types packages provider types, fix casing
hsubox76 Jul 27, 2021
c53ee39
Add typeof?
hsubox76 Jul 28, 2021
0f34629
Read token from storage during initialization
hsubox76 Jul 28, 2021
d7b6cf2
Address PR comments
hsubox76 Jul 30, 2021
c9c364d
Address PR comments
hsubox76 Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app-check-types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ interface AppCheckProvider {
getToken(): Promise<AppCheckToken>;
}

export class ReCAPTCHAV3Provider {
export class ReCaptchaV3Provider {
/**
* @param siteKey - ReCAPTCHA v3 site key (public key).
*/
Expand Down
17 changes: 11 additions & 6 deletions packages/app-check/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,15 @@ import {
} from '@firebase/component';
import {
FirebaseAppCheck,
AppCheckComponentName
AppCheckComponentName,
ReCaptchaV3Provider,
CustomProvider
} from '@firebase/app-check-types';
import { factory, internalFactory } from './factory';
import { ReCaptchaV3Provider, CustomProvider } from './providers';
import {
ReCaptchaV3Provider as ReCaptchaV3ProviderImpl,
CustomProvider as CustomProviderImpl
} from './providers';
import { initializeDebugMode } from './debug';
import { AppCheckInternalComponentName } from '@firebase/app-check-interop-types';
import { name, version } from '../package.json';
Expand All @@ -48,8 +53,8 @@ function registerAppCheck(firebase: _FirebaseNamespace): void {
ComponentType.PUBLIC
)
.setServiceProps({
ReCaptchaV3Provider,
CustomProvider
ReCaptchaV3Provider: ReCaptchaV3ProviderImpl,
CustomProvider: CustomProviderImpl
})
/**
* AppCheck can only be initialized by explicitly calling firebase.appCheck()
Expand Down Expand Up @@ -99,8 +104,8 @@ initializeDebugMode();
declare module '@firebase/app-types' {
interface FirebaseNamespace {
appCheck(app?: FirebaseApp): FirebaseAppCheck;
ReCaptchaV3Provider: typeof ReCaptchaV3Provider;
CustomProvider: typeof CustomProvider;
ReCaptchaV3Provider: ReCaptchaV3Provider;
CustomProvider: CustomProvider;
}
interface FirebaseApp {
appCheck(): FirebaseAppCheck;
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1545,7 +1545,7 @@ declare namespace firebase.appCheck {
/*
* ReCAPTCHA v3 token provider.
*/
class ReCAPTCHAV3Provider {
class ReCaptchaV3Provider {
/**
* @param siteKey - ReCAPTCHA v3 site key (public key).
*/
Expand Down