Roll bundle with prebuilt #4128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as a separate module.
wu-hui
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
|
| } | ||
| ] | ||
| }), | ||
| ...util.es2017Plugins('browser', /* mangled= */ false) |
There was a problem hiding this comment.
This should be mangled.
There was a problem hiding this comment.
As discussed offline, this should be false.
| } | ||
| ], | ||
| plugins: util.es2017ToEs5Plugins(), | ||
| external: util.resolveNodeExterns, |
There was a problem hiding this comment.
This should be resolveBrowserExterns.
| } | ||
| ] | ||
| }), | ||
| ...util.es2017Plugins('rn', /* mangled= */ false) |
There was a problem hiding this comment.
This should be mangled.
There was a problem hiding this comment.
Same as browser build, this should be false.
Co-authored-by: Sebastian Schmidt <[email protected]>
* Split up firestore and firestore-memory build We need to verify that the Node build still works * Fix sebstian's memory build my separating it further.. * To mangle or not to mangle. * Add the missing return! Co-authored-by: Sebastian Schmidt <[email protected]>
wu-hui
changed the base branch from
wuandy/BundleSourceRearrange
to
wuandy/ReleaseBundles
| @@ -26,15 +25,8 @@ import { SnapshotVersion } from './snapshot_version'; | |||
| * Represents a Firestore bundle saved by the SDK in its local storage. | |||
| */ | |||
| export interface Bundle { | |||
| /** | |||
| readonly id: string; | ||
|
|
||
| /** Schema version of the bundle. */ |
| readonly version: number; | ||
|
|
| @@ -46,9 +38,7 @@ export interface Bundle { | |||
| * Represents a Query saved by the SDK in its local storage. | |||
| */ | |||
| export interface NamedQuery { | |||
| /** The name of the query. */ | |||
| readonly name: string; | ||
| /** The underlying query associated with `name`. */ |
schmidt-sebastian
approved these changes
Dec 3, 2020
wu-hui
added a commit
that referenced
this pull request
Dec 8, 2020
* Add bundles to d.ts and rearrange bundles source code for building it as a separate module (#4120) * Add bundles to d.ts and rearrange bundles source code for building it as a separate module. * Roll bundle with prebuilt (#4128) Build firestore sdks with prebuilt to support bundle as a prototype patched feature. * Add JSDoc for bundles (#4155) Add JSDoc for bundles. * Create changeset * Update old-lobsters-pull.md * A few fixes for Firestore bundle sdk builds (#4177) * Actually creates firebase/firestore/bundle package.json * Fix standard node/browser builds for bundles * Make it release from remote branch. * Add bundle to firebase complete build and fix missing proto for memory build. * Make rollup.config.js more organized. * Revert "Make it release from remote branch." This reverts commit 2c91fd1. * 2017 -> 2020 * Update comment. * Address comments * Update .changeset/old-lobsters-pull.md Co-authored-by: Sebastian Schmidt <[email protected]> * Update .changeset/old-lobsters-pull.md Co-authored-by: Sebastian Schmidt <[email protected]> * Add toc. * Remove webpack change. Co-authored-by: Sebastian Schmidt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.