A few fixes for Firestore bundle sdk builds #4177
Conversation
This reverts commit 2c91fd1.
wu-hui
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
|
| @@ -111,7 +117,7 @@ const appBuilds = [ | |||
|
|
|||
| const componentBuilds = pkg.components | |||
| // The "app" component is treated differently because it doesn't depend on itself. | |||
| .filter(component => component !== 'app') | |||
| .filter(component => component !== 'app' && component !== 'firestore') | |||
There was a problem hiding this comment.
Please update comment.
| sourcemap: true | ||
| } | ||
| ], | ||
| plugins, |
There was a problem hiding this comment.
Do we not need
uglify({
output: {
ascii_only: true // escape unicode chars
}
})
There was a problem hiding this comment.
The index.ts is just import '@firebase/firestore'; (so is the output), I think we can skip it here.
| @@ -24,6 +24,7 @@ import '../database'; | |||
| // `atob`). We should provide a RN build that works out of the box. | |||
| import '../storage'; | |||
| import '../firestore'; | |||
| import '../firestore/bundle'; | |||
There was a problem hiding this comment.
The React Nativce build of the main Firestore package splits up bundles and non-bundled code. I think we should do the same here.
There was a problem hiding this comment.
This is for "complete" build, which include everything (except memory only builds) on other platforms.
* Add bundles to d.ts and rearrange bundles source code for building it as a separate module (#4120) * Add bundles to d.ts and rearrange bundles source code for building it as a separate module. * Roll bundle with prebuilt (#4128) Build firestore sdks with prebuilt to support bundle as a prototype patched feature. * Add JSDoc for bundles (#4155) Add JSDoc for bundles. * Create changeset * Update old-lobsters-pull.md * A few fixes for Firestore bundle sdk builds (#4177) * Actually creates firebase/firestore/bundle package.json * Fix standard node/browser builds for bundles * Make it release from remote branch. * Add bundle to firebase complete build and fix missing proto for memory build. * Make rollup.config.js more organized. * Revert "Make it release from remote branch." This reverts commit 2c91fd1. * 2017 -> 2020 * Update comment. * Address comments * Update .changeset/old-lobsters-pull.md Co-authored-by: Sebastian Schmidt <[email protected]> * Update .changeset/old-lobsters-pull.md Co-authored-by: Sebastian Schmidt <[email protected]> * Add toc. * Remove webpack change. Co-authored-by: Sebastian Schmidt <[email protected]>
firebase/firestore/bundleandfirebase/firestore/memory/bundle.