Skip to content

Separate memory build further. #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 3, 2020
Merged

Separate memory build further. #4143

merged 5 commits into from
Dec 3, 2020

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Dec 1, 2020

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2020 •
edited
Loading

⚠️ No Changeset found

Latest commit: 161e64a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

schmidt-sebastian
schmidt-sebastian reviewed Dec 1, 2020
View reviewed changes
packages/firebase/firestore/memory/index.ts
@@ -21,4 +21,4 @@
*/

import '@firebase/firestore/memory';
import '@firebase/firestore/bundle';
import '@firebase/firestore/memory-bundle';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be @firebase/firestore/memory/bundle?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cannot be done gracefully.

The reason is relative paths in packages/firestore/memory-bundle/package.json are interpreted in different context (in rollup or in Typescript import from packages/firebase/firestore/...) and therefore some of them need to be prefixed ../.. and some of them just ../, which is confusing.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 1, 2020 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (b08248a) and head commit (367dc17).

Test Logs

wu-hui added 3 commits December 1, 2020 21:12
@wu-hui
Merge branch 'wuandy/RollBundlesAsPatchedModule' into wuandy/FixSebas…
4499213 
…tiansSeparateMemoryBuild

# Conflicts:
#	packages/firestore/rollup.config.browser.js
#	packages/firestore/rollup.config.rn.js
@wu-hui
To mangle or not to mangle.
c2c2d90
@wu-hui
Add the missing return!
161e64a
@wu-hui wu-hui changed the base branch from mrschmidt/RollBundlesAsPatchedModuleV2 to wuandy/RollBundlesAsPatchedModule December 3, 2020 14:28
@wu-hui
Copy link
Contributor Author

wu-hui commented Dec 3, 2020

I will merge this into wuandy/RollBundlesAsPatchedModule and let's review that PR.

@wu-hui wu-hui merged commit 68f162a into wuandy/RollBundlesAsPatchedModule Dec 3, 2020
@firebase firebase locked and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian left review comments

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @schmidt-sebastian