Partial Typings Revert #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshcrowthe
requested review from
mikelehen and
schmidt-sebastian
as code owners
|
👍 |
|
This would be great. Holding on 4.8.0 until a consensus is reached on this. |
hiranya911
approved these changes
Jan 8, 2018
| "devDependencies": { | ||
| "typescript": "^2.4.2" | ||
| } | ||
| } |
|
This has been prereleased under the |
|
Thanks @jshcrowthe & @hiranya911 ! Looks like its working. Been using it in a ionic project since yesterday. Will keep an eye out for any issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had several issues (e.g. #393, #392, #387, #388) related to the typings change that was made.
This change reverts the changes that were made to the top-level
firebaseNPM package. Packages depending on that should no longer be broken, but this change preserves the changes in the Semver major 0@firebase/*packages.Users who are on the old types consuming through the
firebasepackage, should see issues resolved, while users who are on the experimental@firebase/*packages should not have to update their apps again.