Skip to content

Partial Typings Revert #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 8, 2018
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,14 @@
* limitations under the License.
*/

import '@firebase/auth';
import * as firebase from 'firebase';

/**
* Verifying the namespace types are properly exposed from the `firebase`
* package
*/
let app: firebase.app.App;
let database: firebase.database.Database;
let firestore: firebase.firestore.Firestore;
let messaging: firebase.messaging.Messaging;
let storage: firebase.storage.Storage;
14 changes: 14 additions & 0 deletions integration/firebase-typings/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"name": "firebase-package-typings-test",
"private": true,
"version": "0.1.0",
"scripts": {
"test": "tsc index.ts --outDir dist"
},
"dependencies": {
"firebase": "4.8.1"
},
"devDependencies": {
"typescript": "^2.4.2"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"dev": "lerna run --parallel --scope @firebase/* --scope firebase dev",
"prepare": "lerna run --scope @firebase/* --scope firebase prepare",
"prepush": "node tools/gitHooks/prepush.js",
"link:packages": "lerna exec --scope @firebase/* --scope firebase -- yarn link",
"stage:packages": "./scripts/prepublish.sh",
"prepublish:packages": "./scripts/prepublish.sh --prod",
"publish:packages": "./scripts/publish.sh",
Expand Down
2 changes: 2 additions & 0 deletions packages/database-types/test/default.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,5 @@

import { firebase } from '@firebase/app';
import '@firebase/database';

firebase.database.Database;
1 change: 1 addition & 0 deletions packages/database/index.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ declare module '@firebase/app-types' {
(app?: FirebaseApp): types.FirebaseDatabase;
enableLogging: typeof types.enableLogging;
ServerValue: types.ServerValue;
Database: typeof types.FirebaseDatabase;
};
}
interface FirebaseApp {
Expand Down
1 change: 1 addition & 0 deletions packages/database/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ declare module '@firebase/app-types' {
(app?: FirebaseApp): types.FirebaseDatabase;
enableLogging: typeof types.enableLogging;
ServerValue: types.ServerValue;
Database: typeof types.FirebaseDatabase;
};
}
interface FirebaseApp {
Expand Down
Loading