-
Notifications
You must be signed in to change notification settings - Fork 926
Partial Typings Revert #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7c7a821
Partial revert of a6b6689 to fix wrapper package typings
jshcrowthe a4b804e
Add helper to setup links to all packages
jshcrowthe 043f22b
[AUTOMATED]: Prettier Code Styling
jshcrowthe aa4b65c
Add a simple test to validate that the typings are properly exported
jshcrowthe ac991e9
[AUTOMATED]: Prettier Code Styling
jshcrowthe a74e1fc
[AUTOMATED]: License Headers
jshcrowthe 38e8cc6
Merge branch 'master' into typings-revert
jshcrowthe b9f9b3e
Fix database typings issue
jshcrowthe de3ddd2
[AUTOMATED]: Prettier Code Styling
jshcrowthe 50fe1ca
Merge branch 'master' into typings-revert
jshcrowthe db087ac
Fixing nit from @hiranya911
jshcrowthe 229305f
Merge branch 'master' into typings-revert
jshcrowthe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
{ | ||
"name": "firebase-package-typings-test", | ||
"private": true, | ||
"version": "0.1.0", | ||
"scripts": { | ||
"test": "tsc index.ts --outDir dist" | ||
}, | ||
"dependencies": { | ||
"firebase": "4.8.1" | ||
}, | ||
"devDependencies": { | ||
"typescript": "^2.4.2" | ||
} | ||
} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,3 +16,5 @@ | |
|
||
import { firebase } from '@firebase/app'; | ||
import '@firebase/database'; | ||
|
||
firebase.database.Database; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add new line