Skip to content

Commit 84a7e79

Browse files
authored
Partial Typings Revert (#401)
* Partial revert of a6b6689 to fix wrapper package typings * Add helper to setup links to all packages * [AUTOMATED]: Prettier Code Styling * Add a simple test to validate that the typings are properly exported * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * Fix database typings issue * [AUTOMATED]: Prettier Code Styling * Fixing nit from @hiranya911
1 parent 7789ad5 commit 84a7e79

File tree

14 files changed

+3224
-116
lines changed

14 files changed

+3224
-116
lines changed

packages/firebase/auth/index.d.ts renamed to integration/firebase-typings/index.ts

+11-1
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,14 @@
1414
* limitations under the License.
1515
*/
1616

17-
import '@firebase/auth';
17+
import * as firebase from 'firebase';
18+
19+
/**
20+
* Verifying the namespace types are properly exposed from the `firebase`
21+
* package
22+
*/
23+
let app: firebase.app.App;
24+
let database: firebase.database.Database;
25+
let firestore: firebase.firestore.Firestore;
26+
let messaging: firebase.messaging.Messaging;
27+
let storage: firebase.storage.Storage;
+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
{
2+
"name": "firebase-package-typings-test",
3+
"private": true,
4+
"version": "0.1.0",
5+
"scripts": {
6+
"test": "tsc index.ts --outDir dist"
7+
},
8+
"dependencies": {
9+
"firebase": "4.8.1"
10+
},
11+
"devDependencies": {
12+
"typescript": "^2.4.2"
13+
}
14+
}

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
"dev": "lerna run --parallel --scope @firebase/* --scope firebase dev",
1919
"prepare": "lerna run --scope @firebase/* --scope firebase prepare",
2020
"prepush": "node tools/gitHooks/prepush.js",
21+
"link:packages": "lerna exec --scope @firebase/* --scope firebase -- yarn link",
2122
"stage:packages": "./scripts/prepublish.sh",
2223
"prepublish:packages": "./scripts/prepublish.sh --prod",
2324
"publish:packages": "./scripts/publish.sh",

packages/database-types/test/default.test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,5 @@
1616

1717
import { firebase } from '@firebase/app';
1818
import '@firebase/database';
19+
20+
firebase.database.Database;

packages/database/index.node.ts

+1
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ declare module '@firebase/app-types' {
9191
(app?: FirebaseApp): types.FirebaseDatabase;
9292
enableLogging: typeof types.enableLogging;
9393
ServerValue: types.ServerValue;
94+
Database: typeof types.FirebaseDatabase;
9495
};
9596
}
9697
interface FirebaseApp {

packages/database/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ declare module '@firebase/app-types' {
6767
(app?: FirebaseApp): types.FirebaseDatabase;
6868
enableLogging: typeof types.enableLogging;
6969
ServerValue: types.ServerValue;
70+
Database: typeof types.FirebaseDatabase;
7071
};
7172
}
7273
interface FirebaseApp {

0 commit comments

Comments
 (0)