Remote Config Modularization #3975

Feiyang1 · 2020-10-21T22:40:23Z

The internal implementation is unchanged (clients and storage). They are created when you initialize remote config and are members of the remote config object, unchanged from the current behavior. It's possible to modularize them, so that they are only included when you import functions that use them, e.g. fetchConfig, but it probably doesn't provide any real benefits since everyone who uses RC uses fetchConfig.

There are lots of files in this PR, but most of them are just copied and unchanged. Only the following files are changed/added/deleted:

Changed:

src/remote_config.ts
test/remote_config.test.ts
package.json
index.d.ts in remote-config-types-exp

Added:

src/api.ts
src/api2.ts
src/index.ts
src/register.ts
api-extractor.json

TODOs (will address in separate PRs to keep this PR reasonable in terms of size):

Update demo app using modular APIs
Add documentation
Compat package

google-oss-bot · 2020-10-21T23:00:56Z

Binary Size Report

Affected SDKs

No changes between base commit (6f06d84) and head commit (bb7c5eb).

Test Logs

Base (6f06d840): https://github.com/firebase/firebase-js-sdk/actions/runs/334750265
Head (bb7c5eb7): https://github.com/firebase/firebase-js-sdk/actions/runs/336225315

google-oss-bot · 2020-10-21T23:09:46Z

Size Analysis Report

Affected Products

`@firebase/remote-config-exp`

`activate`

Size

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
size	?	10.4 kB	? (?)
size_with_ext_deps	?	27.0 kB	? (?)

Dependencies

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
functions	?	Click to show 9 deps `activate` `asRemoteConfigImpl` `ensureInitialized` `getUserLanguage` `isRetriableError` `openDatabase` `registerRemoteConfig` `setAbortableTimeout` `toFirebaseError`	?
classes	?	Click to show 6 deps `CachingClient` `RemoteConfig` `RestClient` `RetryingClient` `Storage` `StorageCache`	?
variables	?	Click to show 10 deps `APP_NAMESPACE_STORE` `DB_NAME` `DB_VERSION` `DEFAULT_CACHE_MAX_AGE_MILLIS` `DEFAULT_FETCH_TIMEOUT_MILLIS` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `RC_COMPONENT_NAME` `name` `version`	?

External Dependencies

Module	Base (`7c15fb0`)	Head (`73be89b`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `FirebaseError` `calculateBackoffMillis`	?
`@firebase/app-exp`	?	`SDK_VERSION` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`ensureInitialized`

Size

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
size	?	10.0 kB	? (?)
size_with_ext_deps	?	26.7 kB	? (?)

Dependencies

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
functions	?	Click to show 7 deps `ensureInitialized` `getUserLanguage` `isRetriableError` `openDatabase` `registerRemoteConfig` `setAbortableTimeout` `toFirebaseError`	?
classes	?	Click to show 6 deps `CachingClient` `RemoteConfig` `RestClient` `RetryingClient` `Storage` `StorageCache`	?
variables	?	Click to show 10 deps `APP_NAMESPACE_STORE` `DB_NAME` `DB_VERSION` `DEFAULT_CACHE_MAX_AGE_MILLIS` `DEFAULT_FETCH_TIMEOUT_MILLIS` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `RC_COMPONENT_NAME` `name` `version`	?

External Dependencies

Module	Base (`7c15fb0`)	Head (`73be89b`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `FirebaseError` `calculateBackoffMillis`	?
`@firebase/app-exp`	?	`SDK_VERSION` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`fetchAndActivate`

Size

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
size	?	11.0 kB	? (?)
size_with_ext_deps	?	27.6 kB	? (?)

Dependencies

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
functions	?	Click to show 12 deps `activate` `asRemoteConfigImpl` `ensureInitialized` `fetchAndActivate` `fetchConfig` `getUserLanguage` `hasErrorCode` `isRetriableError` `openDatabase` `registerRemoteConfig` `setAbortableTimeout` `toFirebaseError`	?
classes	?	Click to show 7 deps `CachingClient` `RemoteConfig` `RemoteConfigAbortSignal` `RestClient` `RetryingClient` `Storage` `StorageCache`	?
variables	?	Click to show 10 deps `APP_NAMESPACE_STORE` `DB_NAME` `DB_VERSION` `DEFAULT_CACHE_MAX_AGE_MILLIS` `DEFAULT_FETCH_TIMEOUT_MILLIS` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `RC_COMPONENT_NAME` `name` `version`	?

External Dependencies

Module	Base (`7c15fb0`)	Head (`73be89b`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `FirebaseError` `calculateBackoffMillis`	?
`@firebase/app-exp`	?	`SDK_VERSION` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`fetchConfig`

Size

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
size	?	10.6 kB	? (?)
size_with_ext_deps	?	27.3 kB	? (?)

Dependencies

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
functions	?	Click to show 10 deps `asRemoteConfigImpl` `ensureInitialized` `fetchConfig` `getUserLanguage` `hasErrorCode` `isRetriableError` `openDatabase` `registerRemoteConfig` `setAbortableTimeout` `toFirebaseError`	?
classes	?	Click to show 7 deps `CachingClient` `RemoteConfig` `RemoteConfigAbortSignal` `RestClient` `RetryingClient` `Storage` `StorageCache`	?
variables	?	Click to show 10 deps `APP_NAMESPACE_STORE` `DB_NAME` `DB_VERSION` `DEFAULT_CACHE_MAX_AGE_MILLIS` `DEFAULT_FETCH_TIMEOUT_MILLIS` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `RC_COMPONENT_NAME` `name` `version`	?

External Dependencies

Module	Base (`7c15fb0`)	Head (`73be89b`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `FirebaseError` `calculateBackoffMillis`	?
`@firebase/app-exp`	?	`SDK_VERSION` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`getAll`

Size

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
size	?	11.2 kB	? (?)
size_with_ext_deps	?	27.9 kB	? (?)

Dependencies

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
functions	?	Click to show 11 deps `asRemoteConfigImpl` `ensureInitialized` `getAll` `getAllKeys` `getUserLanguage` `getValue` `isRetriableError` `openDatabase` `registerRemoteConfig` `setAbortableTimeout` `toFirebaseError`	?
classes	?	Click to show 7 deps `CachingClient` `RemoteConfig` `RestClient` `RetryingClient` `Storage` `StorageCache` `Value`	?
variables	?	Click to show 14 deps `APP_NAMESPACE_STORE` `BOOLEAN_TRUTHY_VALUES` `DB_NAME` `DB_VERSION` `DEFAULT_CACHE_MAX_AGE_MILLIS` `DEFAULT_FETCH_TIMEOUT_MILLIS` `DEFAULT_VALUE_FOR_BOOLEAN` `DEFAULT_VALUE_FOR_NUMBER` `DEFAULT_VALUE_FOR_STRING` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `RC_COMPONENT_NAME` `name` `version`	?

External Dependencies

Module	Base (`7c15fb0`)	Head (`73be89b`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `FirebaseError` `calculateBackoffMillis`	?
`@firebase/app-exp`	?	`SDK_VERSION` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`getBoolean`

Size

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
size	?	11.1 kB	? (?)
size_with_ext_deps	?	27.7 kB	? (?)

Dependencies

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
functions	?	Click to show 10 deps `asRemoteConfigImpl` `ensureInitialized` `getBoolean` `getUserLanguage` `getValue` `isRetriableError` `openDatabase` `registerRemoteConfig` `setAbortableTimeout` `toFirebaseError`	?
classes	?	Click to show 7 deps `CachingClient` `RemoteConfig` `RestClient` `RetryingClient` `Storage` `StorageCache` `Value`	?
variables	?	Click to show 14 deps `APP_NAMESPACE_STORE` `BOOLEAN_TRUTHY_VALUES` `DB_NAME` `DB_VERSION` `DEFAULT_CACHE_MAX_AGE_MILLIS` `DEFAULT_FETCH_TIMEOUT_MILLIS` `DEFAULT_VALUE_FOR_BOOLEAN` `DEFAULT_VALUE_FOR_NUMBER` `DEFAULT_VALUE_FOR_STRING` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `RC_COMPONENT_NAME` `name` `version`	?

External Dependencies

Module	Base (`7c15fb0`)	Head (`73be89b`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `FirebaseError` `calculateBackoffMillis`	?
`@firebase/app-exp`	?	`SDK_VERSION` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`getNumber`

Size

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
size	?	11.1 kB	? (?)
size_with_ext_deps	?	27.7 kB	? (?)

Dependencies

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
functions	?	Click to show 10 deps `asRemoteConfigImpl` `ensureInitialized` `getNumber` `getUserLanguage` `getValue` `isRetriableError` `openDatabase` `registerRemoteConfig` `setAbortableTimeout` `toFirebaseError`	?
classes	?	Click to show 7 deps `CachingClient` `RemoteConfig` `RestClient` `RetryingClient` `Storage` `StorageCache` `Value`	?
variables	?	Click to show 14 deps `APP_NAMESPACE_STORE` `BOOLEAN_TRUTHY_VALUES` `DB_NAME` `DB_VERSION` `DEFAULT_CACHE_MAX_AGE_MILLIS` `DEFAULT_FETCH_TIMEOUT_MILLIS` `DEFAULT_VALUE_FOR_BOOLEAN` `DEFAULT_VALUE_FOR_NUMBER` `DEFAULT_VALUE_FOR_STRING` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `RC_COMPONENT_NAME` `name` `version`	?

External Dependencies

Module	Base (`7c15fb0`)	Head (`73be89b`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `FirebaseError` `calculateBackoffMillis`	?
`@firebase/app-exp`	?	`SDK_VERSION` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`getRemoteConfig`

Size

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
size	?	10.1 kB	? (?)
size_with_ext_deps	?	26.7 kB	? (?)

Dependencies

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
functions	?	Click to show 8 deps `ensureInitialized` `getRemoteConfig` `getUserLanguage` `isRetriableError` `openDatabase` `registerRemoteConfig` `setAbortableTimeout` `toFirebaseError`	?
classes	?	Click to show 6 deps `CachingClient` `RemoteConfig` `RestClient` `RetryingClient` `Storage` `StorageCache`	?
variables	?	Click to show 10 deps `APP_NAMESPACE_STORE` `DB_NAME` `DB_VERSION` `DEFAULT_CACHE_MAX_AGE_MILLIS` `DEFAULT_FETCH_TIMEOUT_MILLIS` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `RC_COMPONENT_NAME` `name` `version`	?

External Dependencies

Module	Base (`7c15fb0`)	Head (`73be89b`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `FirebaseError` `calculateBackoffMillis`	?
`@firebase/app-exp`	?	`SDK_VERSION` `_getProvider` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`getString`

Size

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
size	?	11.1 kB	? (?)
size_with_ext_deps	?	27.7 kB	? (?)

Dependencies

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
functions	?	Click to show 10 deps `asRemoteConfigImpl` `ensureInitialized` `getString` `getUserLanguage` `getValue` `isRetriableError` `openDatabase` `registerRemoteConfig` `setAbortableTimeout` `toFirebaseError`	?
classes	?	Click to show 7 deps `CachingClient` `RemoteConfig` `RestClient` `RetryingClient` `Storage` `StorageCache` `Value`	?
variables	?	Click to show 14 deps `APP_NAMESPACE_STORE` `BOOLEAN_TRUTHY_VALUES` `DB_NAME` `DB_VERSION` `DEFAULT_CACHE_MAX_AGE_MILLIS` `DEFAULT_FETCH_TIMEOUT_MILLIS` `DEFAULT_VALUE_FOR_BOOLEAN` `DEFAULT_VALUE_FOR_NUMBER` `DEFAULT_VALUE_FOR_STRING` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `RC_COMPONENT_NAME` `name` `version`	?

External Dependencies

Module	Base (`7c15fb0`)	Head (`73be89b`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `FirebaseError` `calculateBackoffMillis`	?
`@firebase/app-exp`	?	`SDK_VERSION` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`getValue`

Size

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
size	?	11.0 kB	? (?)
size_with_ext_deps	?	27.7 kB	? (?)

Dependencies

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
functions	?	Click to show 9 deps `asRemoteConfigImpl` `ensureInitialized` `getUserLanguage` `getValue` `isRetriableError` `openDatabase` `registerRemoteConfig` `setAbortableTimeout` `toFirebaseError`	?
classes	?	Click to show 7 deps `CachingClient` `RemoteConfig` `RestClient` `RetryingClient` `Storage` `StorageCache` `Value`	?
variables	?	Click to show 14 deps `APP_NAMESPACE_STORE` `BOOLEAN_TRUTHY_VALUES` `DB_NAME` `DB_VERSION` `DEFAULT_CACHE_MAX_AGE_MILLIS` `DEFAULT_FETCH_TIMEOUT_MILLIS` `DEFAULT_VALUE_FOR_BOOLEAN` `DEFAULT_VALUE_FOR_NUMBER` `DEFAULT_VALUE_FOR_STRING` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `RC_COMPONENT_NAME` `name` `version`	?

External Dependencies

Module	Base (`7c15fb0`)	Head (`73be89b`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `FirebaseError` `calculateBackoffMillis`	?
`@firebase/app-exp`	?	`SDK_VERSION` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`setLogLevel`

Size

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
size	?	10.2 kB	? (?)
size_with_ext_deps	?	26.9 kB	? (?)

Dependencies

Type	Base (`7c15fb0`)	Head (`73be89b`)	Diff
functions	?	Click to show 9 deps `asRemoteConfigImpl` `ensureInitialized` `getUserLanguage` `isRetriableError` `openDatabase` `registerRemoteConfig` `setAbortableTimeout` `setLogLevel` `toFirebaseError`	?
classes	?	Click to show 6 deps `CachingClient` `RemoteConfig` `RestClient` `RetryingClient` `Storage` `StorageCache`	?
variables	?	Click to show 10 deps `APP_NAMESPACE_STORE` `DB_NAME` `DB_VERSION` `DEFAULT_CACHE_MAX_AGE_MILLIS` `DEFAULT_FETCH_TIMEOUT_MILLIS` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `RC_COMPONENT_NAME` `name` `version`	?

External Dependencies

Module	Base (`7c15fb0`)	Head (`73be89b`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `FirebaseError` `calculateBackoffMillis`	?
`@firebase/app-exp`	?	`SDK_VERSION` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

Test Logs

Base (7c15fb0a): https://github.com/firebase/firebase-js-sdk/actions/runs/320812289
Head (73be89be): https://github.com/firebase/firebase-js-sdk/actions/runs/320861405

erikeldridge

Thx, Fei 🙏

packages-exp/remote-config-exp/CHANGELOG.md

erikeldridge · 2020-10-23T22:26:43Z

packages-exp/remote-config-exp/src/api.ts

+}
+
+function asRemoteConfigImpl(remoteConfig: RemoteConfig): RemoteConfigImpl {
+  return remoteConfig as RemoteConfigImpl;


Minor: I'm guessing it's a best-practice to wrap the cast operation, but it's new to me. Is there a doc you'd recommend for the rationale?

Yeah, I don't think it's a best-practice. I didn't want to do casting(using as) in every API, so I moved it to a function. On reflection, I think it's probably not necessary, and will waste cycles by introducing a no-op function call.

Changed to do casting directly in individual functions.

packages-exp/remote-config-exp/src/api2.ts

erikeldridge · 2020-10-26T18:12:51Z

common/api-review/remote-config-exp.api.md

+export function fetchConfig(remoteConfig: RemoteConfig): Promise<void>;
+
+// @public (undocumented)
+export function getAll(remoteConfig: RemoteConfig): Record<string, Value>;


The return type before was object:
https://github.com/firebase/firebase-js-sdk/blob/master/packages/remote-config-types/index.d.ts#L68 -> https://firebase.google.com/docs/reference/js/firebase.remoteconfig.RemoteConfig#getall

Using { [key: string]: Value } still seems idiomatic:
https://www.typescriptlang.org/docs/handbook/interfaces.html#indexable-types

What's the value of using Record?

It's an alias of { [key:string]: Value}. The only reason to use it is it is shorter.

👍 Good to know. Thx

changeset-bot · 2020-10-28T17:55:04Z

⚠️ No Changeset found

Latest commit: f408d8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR

Some errors occurred when validating the changesets config:
The package "@firebase/remote-config-exp" depends on the ignored package "@firebase/app-exp", but "@firebase/remote-config-exp" is not being ignored. Please add "@firebase/remote-config-exp" to the `ignore` option.
The package "@firebase/remote-config-exp" depends on the ignored package "@firebase/app-types-exp", but "@firebase/remote-config-exp" is not being ignored. Please add "@firebase/remote-config-exp" to the `ignore` option.
The package "@firebase/remote-config-exp" depends on the ignored package "@firebase/installations-exp", but "@firebase/remote-config-exp" is not being ignored. Please add "@firebase/remote-config-exp" to the `ignore` option.

* Rolls a node app building bundles. * Build bundle files for given list of project IDs. * Build the bundle json map and save it for integration tests. * Add emulator_settings.ts to gulp * Move bundle.test.ts to api/ * Bundles passes all tests and expose in classic API * Add CI project ID to bundles. * Adhoc string replacement and length re-calculation * Fix lint errors. * Delete old changes from make node app * Address comments * Update yarn.lock for release (#3998) Temp fix where database version is bumped before firebase-admin can update deps * Manually prepares the bundle strings. * Update API * Update config.ts * Use Chrome for karma debugging (#4007) * Cache emulator between runs (#3956) * Remote Config Modularization (#3975) * rc exp init * Add apis * register rc exp * implement funcitonal APIs * fix tests * build rc exp * add api-extractor to rc types * cast directly witout function * delete changelog for rc exp * add code owners to rc exp * update dep version * Remove AuthErrorCode from core export (#4013) * Remove AuthErrorCode from core export * Api * Update config.ts to remove bundles * adds a root changelog (#4009) * adds a root changelog * Update CHANGELOG.md Co-authored-by: Feiyang <[email protected]> * Update dependency typescript to v4.0.5 (#3846) Co-authored-by: Renovate Bot <[email protected]> * Update dependency karma-firefox-launcher to v2 (#3987) Co-authored-by: Renovate Bot <[email protected]> * Update dependency google-closure-library to v20200830 (#3765) * Update dependency google-closure-library to v20200830 * Replace goog.isArray with Array.isArray https://github.com/google/closure-library/releases/tag/v20200628 Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Alex Volkovitsky <[email protected]> * exclude remote config exp packages in changeset (#4014) * Set 1s timeout for onBackgroundMessage Hook (#3780) * await onBackgroundMessage hook * Create fluffy-panthers-hide.md * block in onPush to let onBackgroundMessage to execute * polish wording * Update changeset to be more specific * Update fluffy-panthers-hide.md * Clarify PR is about a bug fix * Update fluffy-panthers-hide.md * A whole bunch of things to bring auth (compat) to parity (#3970) * Handle anonymous auth re-login edge case * Formatting * Initial fixes * Fix redirect * clean up additional user info * Formatting * PR feedback * Fix some tests * Fix tests & write some new ones * Fix broken build * Formatting * Formatting * PR feedback * Formatting * PR feedback Co-authored-by: avolkovi <[email protected]> * Add withFunctionsTriggersDisabled method to rules-unit-testing (#3928) * Update integration tests to use free functions * Functions compat package (#3739) * Add free functions to exports * Fix to avoid false failures on changeset checker (#4012) * Add changeset for Firestore (#4030) * Update functions-compat dep version and fix changeset script error (#4032) * Update integration tests. Minified tests fail. * Bump node memory limit for all test CI (#4035) * Compat Layer for Firestore (#4003) * Rename all public API types to PublicX (#4039) * Update all non-major dependencies (#3953) Co-authored-by: Renovate Bot <[email protected]> * Version Packages (#4033) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Set up Storage modularization (#3499) Refactor storage for modularization. * Free functions removed from exp database.ts Co-authored-by: Christina Holland <[email protected]> Co-authored-by: Sebastian Schmidt <[email protected]> Co-authored-by: Sam Stern <[email protected]> Co-authored-by: Feiyang <[email protected]> Co-authored-by: Sam Horlbeck Olsen <[email protected]> Co-authored-by: Dimitri Mitropoulos <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Alex Volkovitsky <[email protected]> Co-authored-by: Kai Wu <[email protected]> Co-authored-by: Google Open Source Bot <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Feiyang1 added 8 commits October 20, 2020 12:13

rc exp init

b809c8d

Add apis

6e0b16f

register rc exp

fba771f

implement funcitonal APIs

3e314a7

fix tests

77bf463

Merge branch 'master' into fei-rc-exp

0e32757

build rc exp

e87a19a

add api-extractor to rc types

8ac9014

Feiyang1 requested review from hiranya911 and hsubox76 as code owners October 21, 2020 22:40

Feiyang1 assigned erikeldridge Oct 21, 2020

erikeldridge approved these changes Oct 23, 2020

View reviewed changes

erikeldridge reviewed Oct 26, 2020

View reviewed changes

Feiyang1 added 2 commits October 28, 2020 10:52

cast directly witout function

c930b4d

delete changelog for rc exp

0181236

add code owners to rc exp

deaa127

hsubox76 approved these changes Oct 29, 2020

View reviewed changes

Feiyang1 added 2 commits October 28, 2020 20:21

update dep version

864488b

Merge branch 'master' into fei-rc-exp

f408d8d

Feiyang1 merged commit 0c602aa into master Oct 29, 2020

Feiyang1 deleted the fei-rc-exp branch October 29, 2020 16:53

firebase locked and limited conversation to collaborators Nov 29, 2020

Remote Config Modularization #3975

Remote Config Modularization #3975

Conversation

Feiyang1 commented Oct 21, 2020

Changed:

Added:

TODOs (will address in separate PRs to keep this PR reasonable in terms of size):

google-oss-bot commented Oct 21, 2020 • edited Loading

Binary Size Report

Affected SDKs

Test Logs

google-oss-bot commented Oct 21, 2020

Size Analysis Report

Affected Products

@firebase/remote-config-exp

activate

Size

Dependencies

External Dependencies

ensureInitialized

Size

Dependencies

External Dependencies

fetchAndActivate

Size

Dependencies

External Dependencies

fetchConfig

Size

Dependencies

External Dependencies

getAll

Size

Dependencies

External Dependencies

getBoolean

Size

Dependencies

External Dependencies

getNumber

Size

Dependencies

External Dependencies

getRemoteConfig

Size

Dependencies

External Dependencies

getString

Size

Dependencies

External Dependencies

getValue

Size

Dependencies

External Dependencies

setLogLevel

Size

Dependencies

External Dependencies

Test Logs

erikeldridge left a comment

Choose a reason for hiding this comment

erikeldridge Oct 23, 2020

Choose a reason for hiding this comment

Feiyang1 Oct 28, 2020

Choose a reason for hiding this comment

erikeldridge Oct 26, 2020 • edited Loading

Choose a reason for hiding this comment

Feiyang1 Oct 28, 2020 • edited Loading

Choose a reason for hiding this comment

erikeldridge Nov 5, 2020

Choose a reason for hiding this comment

changeset-bot bot commented Oct 28, 2020 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Oct 21, 2020 •

edited

Loading

`@firebase/remote-config-exp`

`activate`

`ensureInitialized`

`fetchAndActivate`

`fetchConfig`

`getAll`

`getBoolean`

`getNumber`

`getRemoteConfig`

`getString`

`getValue`

`setLogLevel`

erikeldridge Oct 26, 2020 •

edited

Loading

Feiyang1 Oct 28, 2020 •

edited

Loading

changeset-bot bot commented Oct 28, 2020 •

edited

Loading