Skip to content

Functions compat package #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 3, 2020
Merged

Functions compat package #3739

merged 11 commits into from
Nov 3, 2020

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Sep 3, 2020

Implementation of backwards-compatible functions layer on top of new modularized functions package.

Compatible with recent changes in: #3906

It may be too soon to remove the deprecated method so functions-compat keeps it and formats the old origin format into host/port args to pass to functions-exp.

@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2020

⚠️ No Changeset found

Latest commit: 413f77b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package "@firebase/functions-compat" depends on the ignored package "@firebase/functions-exp", but "@firebase/functions-compat" is not being ignored. Please add "@firebase/functions-compat" to the `ignore` option.
The package "@firebase/functions-compat" depends on the ignored package "@firebase/functions-types-exp", but "@firebase/functions-compat" is not being ignored. Please add "@firebase/functions-compat" to the `ignore` option.
The package "@firebase/functions-compat" depends on the ignored package "@firebase/app-compat", but "@firebase/functions-compat" is not being ignored. Please add "@firebase/functions-compat" to the `ignore` option.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 3, 2020

Binary Size Report

Affected SDKs

  • @firebase/auth

    Type Base (a9ba7ba) Head (fe39051) Diff
    browser 179 kB 180 kB +404 B (+0.2%)
    main 179 kB 180 kB +404 B (+0.2%)
    module 179 kB 180 kB +404 B (+0.2%)
  • @firebase/firestore

    Type Base (a9ba7ba) Head (fe39051) Diff
    browser 238 kB 241 kB +2.71 kB (+1.1%)
    esm2017 190 kB 190 kB +911 B (+0.5%)
    main 470 kB 475 kB +5.17 kB (+1.1%)
    module 238 kB 241 kB +2.71 kB (+1.1%)
    react-native 190 kB 190 kB +911 B (+0.5%)
  • @firebase/firestore/exp

    Type Base (a9ba7ba) Head (fe39051) Diff
    browser 188 kB 189 kB +1.23 kB (+0.7%)
    main 475 kB 476 kB +1.10 kB (+0.2%)
    module 188 kB 189 kB +1.23 kB (+0.7%)
    react-native 188 kB 189 kB +1.23 kB (+0.7%)
  • @firebase/firestore/lite

    Type Base (a9ba7ba) Head (fe39051) Diff
    browser 61.6 kB 62.9 kB +1.26 kB (+2.0%)
    main 137 kB 139 kB +2.05 kB (+1.5%)
    module 61.6 kB 62.9 kB +1.26 kB (+2.0%)
    react-native 61.8 kB 63.1 kB +1.26 kB (+2.0%)
  • @firebase/firestore/memory

    Type Base (a9ba7ba) Head (fe39051) Diff
    browser 176 kB 177 kB +1.29 kB (+0.7%)
    esm2017 140 kB 139 kB -312 B (-0.2%)
    main 342 kB 344 kB +2.00 kB (+0.6%)
    module 176 kB 177 kB +1.29 kB (+0.7%)
    react-native 140 kB 139 kB -312 B (-0.2%)
  • @firebase/messaging

    Type Base (a9ba7ba) Head (fe39051) Diff
    esm2017 26.0 kB 26.2 kB +188 B (+0.7%)
    main 34.7 kB 34.9 kB +206 B (+0.6%)
    module 34.2 kB 34.4 kB +206 B (+0.6%)
  • @firebase/rules-unit-testing

    Type Base (a9ba7ba) Head (fe39051) Diff
    main 8.00 kB 9.74 kB +1.75 kB (+21.8%)
  • @firebase/util

    Type Base (a9ba7ba) Head (fe39051) Diff
    browser 20.1 kB 20.2 kB +69 B (+0.3%)
    esm2017 18.9 kB 19.0 kB +69 B (+0.4%)
    main 21.3 kB 21.3 kB +69 B (+0.3%)
    module 20.1 kB 20.2 kB +69 B (+0.3%)
  • @firebase/webchannel-wrapper

    Type Base (a9ba7ba) Head (fe39051) Diff
    esm2017 39.3 kB 39.0 kB -280 B (-0.7%)
    main 46.7 kB 46.4 kB -282 B (-0.6%)
    module 40.6 kB 40.3 kB -282 B (-0.7%)
  • firebase

    Type Base (a9ba7ba) Head (fe39051) Diff
    firebase-app.js 20.0 kB 20.0 kB +17 B (+0.1%)
    firebase-auth.js 176 kB 176 kB +368 B (+0.2%)
    firebase-database.js 190 kB 190 kB +17 B (+0.0%)
    firebase-firestore.js 277 kB 280 kB +2.33 kB (+0.8%)
    firebase-firestore.memory.js 217 kB 217 kB +956 B (+0.4%)
    firebase-messaging.js 40.7 kB 40.8 kB +52 B (+0.1%)
    firebase-performance-standalone.es2017.js 71.7 kB 71.7 kB +18 B (+0.0%)
    firebase-performance-standalone.js 48.1 kB 48.1 kB +17 B (+0.0%)
    firebase.js 820 kB 822 kB +2.78 kB (+0.3%)

Test Logs

@google-oss-bot

This comment has been minimized.

@hsubox76 hsubox76 force-pushed the ch-functions-compat branch from 46b6c87 to d0edb2a Compare October 13, 2020 00:02
@hsubox76 hsubox76 changed the title WIP: Functions compat package Functions compat package Oct 13, 2020
@hsubox76 hsubox76 force-pushed the ch-functions-compat branch from d0edb2a to 4babd29 Compare October 14, 2020 16:48
@hsubox76 hsubox76 force-pushed the ch-functions-compat branch from 4babd29 to 7c5a9dd Compare October 27, 2020 20:04
},
"devDependencies": {
"@firebase/app-compat": "0.0.800",
"@firebase/app-exp": "0.0.800",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hsubox76 hsubox76 merged commit a74a1d1 into master Nov 3, 2020
wu-hui added a commit that referenced this pull request Nov 9, 2020
* Rolls a node app building bundles.

* Build bundle files for given list of project IDs.

* Build the bundle json map and save it for integration tests.

* Add emulator_settings.ts to gulp

* Move bundle.test.ts to api/

* Bundles passes all tests and expose in classic API

* Add CI project ID to bundles.

* Adhoc string replacement and length re-calculation

* Fix lint errors.

* Delete old changes from make node app

* Address comments

* Update yarn.lock for release (#3998)

Temp fix where database version is bumped before firebase-admin can update deps

* Manually prepares the bundle strings.

* Update API

* Update config.ts

* Use Chrome for karma debugging (#4007)

* Cache emulator between runs (#3956)

* Remote Config Modularization (#3975)

* rc exp init

* Add apis

* register rc exp

* implement funcitonal APIs

* fix tests

* build rc exp

* add api-extractor to rc types

* cast directly witout function

* delete changelog for rc exp

* add code owners to rc exp

* update dep version

* Remove AuthErrorCode from core export (#4013)

* Remove AuthErrorCode from core export

* Api

* Update config.ts to remove bundles

* adds a root changelog (#4009)

* adds a root changelog

* Update CHANGELOG.md

Co-authored-by: Feiyang <[email protected]>

* Update dependency typescript to v4.0.5 (#3846)

Co-authored-by: Renovate Bot <[email protected]>

* Update dependency karma-firefox-launcher to v2 (#3987)

Co-authored-by: Renovate Bot <[email protected]>

* Update dependency google-closure-library to v20200830 (#3765)

* Update dependency google-closure-library to v20200830

* Replace goog.isArray with Array.isArray

https://github.com/google/closure-library/releases/tag/v20200628

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Alex Volkovitsky <[email protected]>

* exclude remote config exp packages in changeset (#4014)

* Set 1s timeout for onBackgroundMessage Hook (#3780)

* await onBackgroundMessage hook

* Create fluffy-panthers-hide.md

* block in onPush to let onBackgroundMessage to execute

* polish wording

* Update changeset

to be more specific

* Update fluffy-panthers-hide.md

* Clarify PR is about a bug fix

* Update fluffy-panthers-hide.md

* A whole bunch of things to bring auth (compat) to parity (#3970)

* Handle anonymous auth re-login edge case

* Formatting

* Initial fixes

* Fix redirect

* clean up additional user info

* Formatting

* PR feedback

* Fix some tests

* Fix tests & write some new ones

* Fix broken build

* Formatting

* Formatting

* PR feedback

* Formatting

* PR feedback

Co-authored-by: avolkovi <[email protected]>

* Add withFunctionsTriggersDisabled method to rules-unit-testing (#3928)

* Update integration tests to use free functions

* Functions compat package (#3739)

* Add free functions to exports

* Fix to avoid false failures on changeset checker (#4012)

* Add changeset for Firestore (#4030)

* Update functions-compat dep version and fix changeset script error (#4032)

* Update integration tests. Minified tests fail.

* Bump node memory limit for all test CI (#4035)

* Compat Layer for Firestore (#4003)

* Rename all public API types to PublicX (#4039)

* Update all non-major dependencies (#3953)

Co-authored-by: Renovate Bot <[email protected]>

* Version Packages (#4033)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Set up Storage modularization (#3499)

Refactor storage for modularization.

* Free functions removed from exp database.ts

Co-authored-by: Christina Holland <[email protected]>
Co-authored-by: Sebastian Schmidt <[email protected]>
Co-authored-by: Sam Stern <[email protected]>
Co-authored-by: Feiyang <[email protected]>
Co-authored-by: Sam Horlbeck Olsen <[email protected]>
Co-authored-by: Dimitri Mitropoulos <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Alex Volkovitsky <[email protected]>
Co-authored-by: Kai Wu <[email protected]>
Co-authored-by: Google Open Source Bot <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@firebase firebase locked and limited conversation to collaborators Dec 3, 2020
@hsubox76 hsubox76 deleted the ch-functions-compat branch January 21, 2021 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants