Skip to content

Bundles as free functions #4006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
Nov 9, 2020
Merged

Bundles as free functions #4006

merged 49 commits into from
Nov 9, 2020

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Oct 28, 2020

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2020

🦋 Changeset detected

Latest commit: 462efdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wu-hui and others added 3 commits October 28, 2020 17:01
# Conflicts:
#	packages/firebase/index.d.ts
#	packages/firestore/exp/src/api/database.ts
#	packages/firestore/src/api/database.ts
#	packages/firestore/src/core/firestore_client.ts
#	packages/firestore/test/integration/api/bundle.test.ts
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2020

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

    • @firebase/auth-exp
    • @firebase/database
    • firebase
    • @firebase/firestore-types
    • @firebase/firestore

    Make sure this was intentional.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 29, 2020

Binary Size Report

Affected SDKs

  • @firebase/auth

    Type Base (878a1bf) Head (f594840) Diff
    browser 179 kB 180 kB +404 B (+0.2%)
    main 179 kB 180 kB +404 B (+0.2%)
    module 179 kB 180 kB +404 B (+0.2%)
  • @firebase/firestore

    Type Base (878a1bf) Head (f594840) Diff
    browser 241 kB 254 kB +12.7 kB (+5.3%)
    esm2017 190 kB 200 kB +9.17 kB (+4.8%)
    main 475 kB 499 kB +23.9 kB (+5.0%)
    module 241 kB 254 kB +12.7 kB (+5.3%)
    react-native 190 kB 200 kB +9.17 kB (+4.8%)
  • @firebase/firestore/exp

    Type Base (878a1bf) Head (f594840) Diff
    browser 189 kB 198 kB +9.19 kB (+4.9%)
    main 476 kB 500 kB +24.0 kB (+5.0%)
    module 189 kB 198 kB +9.19 kB (+4.9%)
    react-native 189 kB 198 kB +9.19 kB (+4.9%)
  • @firebase/firestore/lite

    Type Base (878a1bf) Head (f594840) Diff
    browser 62.9 kB 63.1 kB +231 B (+0.4%)
    main 139 kB 139 kB +244 B (+0.2%)
    module 62.9 kB 63.1 kB +231 B (+0.4%)
    react-native 63.1 kB 63.3 kB +231 B (+0.4%)
  • @firebase/firestore/memory

    Type Base (878a1bf) Head (f594840) Diff
    browser 177 kB 191 kB +13.2 kB (+7.4%)
    esm2017 139 kB 149 kB +9.92 kB (+7.1%)
    main 344 kB 368 kB +24.0 kB (+7.0%)
    module 177 kB 191 kB +13.2 kB (+7.4%)
    react-native 139 kB 149 kB +9.92 kB (+7.1%)
  • @firebase/messaging

    Type Base (878a1bf) Head (f594840) Diff
    esm2017 26.0 kB 26.2 kB +188 B (+0.7%)
    main 34.7 kB 34.9 kB +206 B (+0.6%)
    module 34.2 kB 34.4 kB +206 B (+0.6%)
  • @firebase/rules-unit-testing

    Type Base (878a1bf) Head (f594840) Diff
    main 8.00 kB 9.74 kB +1.75 kB (+21.8%)
  • @firebase/webchannel-wrapper

    Type Base (878a1bf) Head (f594840) Diff
    esm2017 39.3 kB 39.0 kB -280 B (-0.7%)
    main 46.7 kB 46.4 kB -282 B (-0.6%)
    module 40.6 kB 40.3 kB -282 B (-0.7%)
  • firebase

    Type Base (878a1bf) Head (f594840) Diff
    firebase-auth.js 176 kB 176 kB +368 B (+0.2%)
    firebase-firestore.js 280 kB 292 kB +12.0 kB (+4.3%)
    firebase-firestore.memory.js 218 kB 230 kB +12.4 kB (+5.7%)
    firebase-messaging.js 40.7 kB 40.8 kB +52 B (+0.1%)
    firebase.js 822 kB 835 kB +12.4 kB (+1.5%)

Test Logs

Copy link
Contributor

@avolkovi avolkovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the auth change, looks like just whitespace

samtstern and others added 3 commits October 29, 2020 06:15
* rc exp init

* Add apis

* register rc exp

* implement funcitonal APIs

* fix tests

* build rc exp

* add api-extractor to rc types

* cast directly witout function

* delete changelog for rc exp

* add code owners to rc exp

* update dep version
* Remove AuthErrorCode from core export

* Api
@wu-hui wu-hui changed the base branch from master to wuandy/Bundles November 9, 2020 14:49
@wu-hui wu-hui merged commit 5b0526b into wuandy/Bundles Nov 9, 2020
@firebase firebase locked and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants