Move parent/doc/collection back #3679
Conversation
💥 No ChangesetLatest commit: d2fc594 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
schmidt-sebastian
force-pushed
the
mrschmidt/renames-parent
branch
from
70711bc to
ad17ecb
Compare
Binary Size ReportAffected SDKs
Test Logs |
| } else { | ||
| return new DocumentReference( | ||
| this.firestore, | ||
| /* converter= */ null, |
There was a problem hiding this comment.
nit: Can you standardize the constructor argument order for DocumentReference and CollectionReference?
There was a problem hiding this comment.
I missed this in an earlier review when you made the converter nullable, but the converter in the CollectionReference constructor can be readonly.
There was a problem hiding this comment.
Done (changed CollectionReference to match). As for readonly, that is done in the parent class Query and we rely on the Query's converter property here.
| functionName: string, | ||
| argumentName: string, | ||
| argument?: string | ||
| ): asserts argument is string { |
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
As part of go/firestore-next-amendment-amendment, we decided to make
parentonce again a property of CollectionReference and DocumentReference and also to re-adddoc()andcollection()method to these classes (with the old methods staying as is).Tree-shaking will be improved with #3678