Skip to content

Move parent/doc/collection back #3679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 27, 2020
Merged

Move parent/doc/collection back #3679

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad17ecb
Move parent/doc/collection back
schmidt-sebastian Aug 25, 2020
e11615f
Fix tests
schmidt-sebastian Aug 25, 2020
f34d4ca
Fix terser script
schmidt-sebastian Aug 27, 2020
a4059b1
Merge
schmidt-sebastian Aug 27, 2020
d2fc594
Change argument order
schmidt-sebastian Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/firestore/exp-types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,6 @@ export function doc(
reference: DocumentReference<unknown>,
documentPath: string
): DocumentReference<DocumentData>;
export function parent(
reference: CollectionReference<unknown>
): DocumentReference<DocumentData> | null;
export function parent<T>(
reference: DocumentReference<T>
): CollectionReference<T>;
export function collectionGroup(
firestore: FirebaseFirestore,
collectionId: string
Expand Down Expand Up @@ -247,6 +241,9 @@ export class DocumentReference<T = DocumentData> {
readonly path: string;
readonly id: string;

get parent(): CollectionReference<T>;

collection(collectionPath: string): CollectionReference<DocumentData>;
withConverter<U>(converter: FirestoreDataConverter<U>): DocumentReference<U>;
}

Expand Down Expand Up @@ -359,6 +356,10 @@ export class CollectionReference<T = DocumentData> extends Query<T> {
readonly type: 'collection';
readonly id: string;
readonly path: string;

get parent(): DocumentReference<DocumentData> | null;

doc(documentPath?: string): DocumentReference<T>;
withConverter<U>(
converter: FirestoreDataConverter<U>
): CollectionReference<U>;
Expand Down
Loading