Skip to content

Tree-Shake all of Query #3678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Aug 25, 2020

As part of go/firestore-next-amendment-amendment, we are tying CollectionRefereence and DocumentReference together. To reduce the size impact, this PR makes the rest of the Query class tree-shakeable.

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2020

💥 No Changeset

Latest commit: f252efc

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (96076f0) Head (3760ddf) Diff
    browser 249 kB 249 kB -198 B (-0.1%)
    esm2017 196 kB 196 kB -21 B (-0.0%)
    main 476 kB 475 kB -104 B (-0.0%)
    module 247 kB 246 kB -198 B (-0.1%)
    react-native 196 kB 196 kB -21 B (-0.0%)
  • @firebase/firestore/exp

    Type Base (96076f0) Head (3760ddf) Diff
    browser 189 kB 189 kB -21 B (-0.0%)
    main 468 kB 468 kB -104 B (-0.0%)
    module 189 kB 189 kB -21 B (-0.0%)
    react-native 189 kB 189 kB -21 B (-0.0%)
  • @firebase/firestore/lite

    Type Base (96076f0) Head (3760ddf) Diff
    browser 64.7 kB 64.4 kB -296 B (-0.5%)
    main 141 kB 141 kB -616 B (-0.4%)
    module 64.7 kB 64.4 kB -296 B (-0.5%)
    react-native 64.8 kB 64.5 kB -297 B (-0.5%)
  • @firebase/firestore/memory

    Type Base (96076f0) Head (3760ddf) Diff
    browser 187 kB 187 kB -198 B (-0.1%)
    esm2017 147 kB 147 kB -21 B (-0.0%)
    main 349 kB 349 kB -104 B (-0.0%)
    module 185 kB 185 kB -198 B (-0.1%)
    react-native 147 kB 147 kB -21 B (-0.0%)
  • firebase

    Type Base (96076f0) Head (3760ddf) Diff
    firebase-firestore.js 288 kB 287 kB -227 B (-0.1%)
    firebase-firestore.memory.js 227 kB 227 kB -227 B (-0.1%)
    firebase.js 823 kB 823 kB -227 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 25, 2020

Size Analysis Report

Affected Products

No changes between base commit (70537a6) and head commit (dec9424).

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit fee4e8b into master Aug 27, 2020
@firebase firebase locked and limited conversation to collaborators Sep 27, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/renames-treeshaking branch November 9, 2020 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants