Skip to content

Remove 'no-android' tags from spec tests for limbo resolution throttling #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Apr 6, 2020

Limbo resolution throttling is now implemented in Android, and, therefore, the spec tests for that feature should be enabled: firebase/firebase-android-sdk#1374

@dconeybe dconeybe self-assigned this Apr 6, 2020
@google-oss-bot
Copy link
Contributor

@dconeybe dconeybe requested a review from wilhuff April 7, 2020 04:25
@dconeybe dconeybe assigned wilhuff and unassigned dconeybe Apr 7, 2020
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The diff says you actually removed android', 'no- ...

@wilhuff wilhuff assigned dconeybe and unassigned wilhuff Apr 7, 2020
@dconeybe dconeybe merged commit b8cf437 into master Apr 7, 2020
@dconeybe dconeybe deleted the dconeybe/LimboThrottleSpecTestsEnableAndroid branch April 7, 2020 15:41
@firebase firebase locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants