Implement limbo resolution listen throttling. #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconeybe
force-pushed
the
dconeybe/LimboThrottle
branch
from
eab4627 to
9eba6e0
Compare
Binary Size ReportAffected SDKs
Test Logs |
Codecov Report
Continue to review full report at Codecov.
|
dconeybe
force-pushed
the
dconeybe/LimboThrottle
branch
from
9eba6e0 to
6caedce
Compare
dconeybe
force-pushed
the
dconeybe/LimboThrottle
branch
from
6caedce to
3f0d9ff
Compare
|
/test device-check-changed |
Coverage ReportAffected SDKs
Test LogsNotesHTML coverage reports can be produced locally with./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.
|
|||||||||||||||||||||||||||||||||||||||
wilhuff
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
LGTM, though bring in the changelog entry that results from firebase/firebase-js-sdk#2864 before submitting.
|
/test smoke-tests |
This was referenced Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of firebase/firebase-js-sdk#2790 to Android.
The following description was copied from that PR and pasted here for your convenience:
This change was motivated by the following bug report: firebase/firebase-js-sdk#2683. In summary, the issue was that when a large number of documents went into limbo (in this case 15,000 documents) then this would cause 15,000 document listens, which would result in "resource-exhausted" errors. The client would then back off for a bit but would try the listens again, which would again result in "resource-exhausted" errors. And the cycle would continue. Worst of all, the customer was being billed for all of these reads that had no beneficial effects for the clients.
In order to avoid this situation, this PR modifies the limbo resolution logic to "throttle" the limbo resolutions. It does this by allowing at most 100 concurrent limbo resolutions. Limbo resolutions in excess of this limit are queued up and not started until another limbo resolution completes. This fix should avoid the "resource-exhausted" errors and the infinite read loop.