Skip to content

Remove 'no-android' tags from spec tests for limbo resolution throttling #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Remove 'no-android' tags from spec tests for limbo resolution throttling #2876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/firestore/test/unit/specs/limbo_spec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ describeSpec('Limbo Documents:', [], () => {
'Limbo resolution throttling with all results at once from watch',
// TODO(dconeybe) Remove the 'no-*' tags as these platforms implement limbo
// resolution throttling.
['no-android', 'no-ios'],
['no-ios'],
() => {
const query = Query.atPath(path('collection'));
const doc1 = doc('collection/a', 1000, { key: 'a' });
Expand Down Expand Up @@ -721,7 +721,7 @@ describeSpec('Limbo Documents:', [], () => {
'Limbo resolution throttling with results one at a time from watch',
// TODO(dconeybe) Remove the 'no-*' tags as these platforms implement limbo
// resolution throttling.
['no-android', 'no-ios'],
['no-ios'],
() => {
const query = Query.atPath(path('collection'));
const doc1 = doc('collection/a', 1000, { key: 'a' });
Expand Down Expand Up @@ -801,7 +801,7 @@ describeSpec('Limbo Documents:', [], () => {
'Limbo resolution throttling when a limbo listen is rejected.',
// TODO(dconeybe) Remove the 'no-*' tags as these platforms implement limbo
// resolution throttling.
['no-android', 'no-ios'],
['no-ios'],
() => {
const query = Query.atPath(path('collection'));
const doc1 = doc('collection/a', 1000, { key: 'a' });
Expand Down Expand Up @@ -854,7 +854,7 @@ describeSpec('Limbo Documents:', [], () => {
'Limbo resolution throttling with existence filter mismatch',
// TODO(dconeybe) Remove the 'no-*' tags as these platforms implement limbo
// resolution throttling.
['no-android', 'no-ios'],
['no-ios'],
() => {
const query = Query.atPath(path('collection'));
const docA1 = doc('collection/a1', 1000, { key: 'a1' });
Expand Down