Skip to content

get size without comments and whitespaces for NPM scripts #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

Feiyang1
Copy link
Member

replaces #2776

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 20, 2020

Binary Size Report

Affected SDKs

SDKTypeBase (7b129c9)Head (fb3c540)Diff
@firebase/loggermodule10668.004778.00-5890.00 (-55.21%)
esm20177440.003223.00-4217.00 (-56.68%)
main10600.005087.00-5513.00 (-52.01%)
@firebase/storagemodule127710.0062277.00-65433.00 (-51.24%)
esm2017118813.0056137.00-62676.00 (-52.75%)
main127939.0062483.00-65456.00 (-51.16%)
@firebase/utilmodule56475.0018551.00-37924.00 (-67.15%)
browser57469.0019454.00-38015.00 (-66.15%)
esm201755870.0017369.00-38501.00 (-68.91%)
main58195.0019481.00-38714.00 (-66.52%)
@firebase/appreact-native25791.009862.00-15929.00 (-61.76%)
lite-esm201721516.007748.00-13768.00 (-63.99%)
module27290.0011011.00-16279.00 (-59.65%)
browser27375.0011108.00-16267.00 (-59.42%)
esm201724521.009461.00-15060.00 (-61.42%)
main25855.0010105.00-15750.00 (-60.92%)
lite23906.009102.00-14804.00 (-61.93%)
@firebase/firestoremodule653145.00273849.00-379296.00 (-58.07%)
browser656503.00277227.00-379276.00 (-57.77%)
esm2017653149.00273849.00-379300.00 (-58.07%)
main643653.00271345.00-372308.00 (-57.84%)
@firebase/installationsmodule54854.0021544.00-33310.00 (-60.72%)
esm201740678.0016530.00-24148.00 (-59.36%)
main55319.0021995.00-33324.00 (-60.24%)
@firebase/functionsmodule24877.008994.00-15883.00 (-63.85%)
browser25074.009174.00-15900.00 (-63.41%)
esm201720078.007010.00-13068.00 (-65.09%)
main25116.009209.00-15907.00 (-63.33%)
@firebase/webchannel-wrappermodule42212.0041226.00-986.00 (-2.34%)
main41162.0040383.00-779.00 (-1.89%)
@firebase/performancemodule53486.0024914.00-28572.00 (-53.42%)
browser53746.0025158.00-28588.00 (-53.19%)
esm201751099.0023188.00-27911.00 (-54.62%)
main53746.0025158.00-28588.00 (-53.19%)
firebasefirebase-performance-standalone.es2017.js70399.0070398.00-1.00 (-0.00%)
@firebase/analyticsmodule23514.009197.00-14317.00 (-60.89%)
esm201721958.008508.00-13450.00 (-61.25%)
main23856.009515.00-14341.00 (-60.11%)
@firebase/authmodule178781.00177089.00-1692.00 (-0.95%)
main178788.00177099.00-1689.00 (-0.94%)
@firebase/remote-configmodule56958.0022720.00-34238.00 (-60.11%)
browser57355.0023103.00-34252.00 (-59.72%)
esm201744595.0017705.00-26890.00 (-60.30%)
main57355.0023103.00-34252.00 (-59.72%)
@firebase/testingmain12113.006598.00-5515.00 (-45.53%)
@firebase/messagingmodule72147.0030549.00-41598.00 (-57.66%)
esm201749023.0022806.00-26217.00 (-53.48%)
main72611.0031006.00-41605.00 (-57.30%)
@firebase/databasemodule607172.00264057.00-343115.00 (-56.51%)
browser608691.00265575.00-343116.00 (-56.37%)
esm2017564841.00232641.00-332200.00 (-58.81%)
main611262.00266339.00-344923.00 (-56.43%)
@firebase/componentmodule13151.005046.00-8105.00 (-61.63%)
browser13271.005164.00-8107.00 (-61.09%)
esm201711230.003898.00-7332.00 (-65.29%)
main13271.005164.00-8107.00 (-61.09%)
@firebase/polyfillmodule740.00666.00-74.00 (-10.00%)
main792.00733.00-59.00 (-7.45%)
Metric Unit: byte

Test Logs

@schmidt-sebastian
Copy link
Contributor

Oh, this reduces our SDK size by 50%+ across the board. Pretty impressive :)

@Feiyang1 Feiyang1 merged commit 573e4f2 into yifany/size Mar 24, 2020
@Feiyang1 Feiyang1 deleted the fei-size branch March 24, 2020 00:13
yifanyang added a commit that referenced this pull request Mar 24, 2020
* size presubmit check

* add missing semicolons

* report github action url

* Upload size report to the metrics service.

* Cosmetic change.

* get size without comments and whitespaces for NPM scripts (#2777)

* get size without comments and whitespaces for NPM scripts

* use single quotes

* update lock file

Co-authored-by: Feiyang1 <[email protected]>
Co-authored-by: Feiyang <[email protected]>
@firebase firebase locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants