remove comments and whitespaces in builds #2776
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
alikn,
andirayo,
avolkovi,
erikeldridge,
hiranya911,
hsubox76,
jsdt,
sam-gc,
schmidt-sebastian,
scottcrossen,
yuchenshi and
zijianjoy
as code owners
|
Would it be possible to do this a precursor only to the size computation? The comments and whitespace actually help a lot when debugging issues in these builds. |
|
Possibly. I will look into that. |
|
@schmidt-sebastian replaced by #2777 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to enable size presubmit(#2744), this PR removes comments and whitespaces in our builds, so the size diffs are not skewed by comment changes.
Will wait for the CI to finish to see how much latency this change introduces.