remove comments and whitespaces in builds

packages/analytics/package.json

@@ -38,7 +38,7 @@
     "rollup-plugin-json": "4.0.0",
     "rollup-plugin-node-resolve": "5.2.0",
     "rollup-plugin-typescript2": "0.26.0",
-    "rollup-plugin-uglify": "6.0.4",
+    "rollup-plugin-terser": "5.3.0",
     "typescript": "3.8.3"
   },
   "repository": {

packages/analytics/rollup.config.js

@@ -19,6 +19,7 @@ import json from 'rollup-plugin-json';
 import typescriptPlugin from 'rollup-plugin-typescript2';
 import typescript from 'typescript';
 import pkg from './package.json';
+import { terser } from 'rollup-plugin-terser';
 
 const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
@@ -31,7 +32,14 @@ const es5BuildPlugins = [
   typescriptPlugin({
     typescript
   }),
-  json()
+  json(),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
+  })
 ];
 
 const es5Builds = [
@@ -61,7 +69,14 @@ const es2017BuildPlugins = [
       }
     }
   }),
-  json({ preferConst: true })
+  json({ preferConst: true }),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
+  })
 ];
 
 const es2017Builds = [

packages/app/package.json

@@ -40,6 +40,7 @@
     "rollup-plugin-json": "4.0.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.26.0",
+    "rollup-plugin-terser": "5.3.0",
     "typescript": "3.8.3"
   },
   "repository": {

packages/app/rollup.config.js

@@ -19,6 +19,7 @@ import typescriptPlugin from 'rollup-plugin-typescript2';
 import json from 'rollup-plugin-json';
 import typescript from 'typescript';
 import pkg from './package.json';
+import { terser } from 'rollup-plugin-terser';
 
 const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
@@ -31,7 +32,14 @@ const es5BuildPlugins = [
   typescriptPlugin({
     typescript
   }),
-  json()
+  json(),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
+  })
 ];
 
 const es5Builds = [
@@ -93,6 +101,13 @@ const es2017BuildPlugins = [
   }),
   json({
     preferConst: true
+  }),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
   })
 ];
 

packages/component/package.json

@@ -29,6 +29,7 @@
   "devDependencies": {
     "rollup": "2.0.6",
     "rollup-plugin-typescript2": "0.26.0",
+    "rollup-plugin-terser": "5.3.0",
     "typescript": "3.8.3"
   },
   "repository": {

packages/component/rollup.config.js

@@ -18,6 +18,7 @@
 import typescriptPlugin from 'rollup-plugin-typescript2';
 import typescript from 'typescript';
 import pkg from './package.json';
+import { terser } from 'rollup-plugin-terser';
 
 const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
@@ -29,6 +30,13 @@ const deps = Object.keys(
 const es5BuildPlugins = [
   typescriptPlugin({
     typescript
+  }),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
   })
 ];
 
@@ -58,6 +66,13 @@ const es2017BuildPlugins = [
         target: 'es2017'
       }
     }
+  }),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
   })
 ];
 

packages/database/package.json

@@ -38,6 +38,7 @@
     "@firebase/app-types": "0.6.0",
     "rollup": "2.0.6",
     "rollup-plugin-typescript2": "0.26.0",
+    "rollup-plugin-terser": "5.3.0",
     "typescript": "3.8.3"
   },
   "repository": {

packages/database/rollup.config.js

@@ -19,6 +19,7 @@ import json from 'rollup-plugin-json';
 import typescriptPlugin from 'rollup-plugin-typescript2';
 import typescript from 'typescript';
 import pkg from './package.json';
+import { terser } from 'rollup-plugin-terser';
 
 const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
@@ -31,7 +32,14 @@ const es5BuildPlugins = [
   typescriptPlugin({
     typescript
   }),
-  json()
+  json(),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
+  })
 ];
 
 const es5Builds = [
@@ -70,7 +78,14 @@ const es2017BuildPlugins = [
       }
     }
   }),
-  json({ preferConst: true })
+  json({ preferConst: true }),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
+  })
 ];
 
 const es2017Builds = [

packages/firestore/terser.config.js

@@ -44,7 +44,7 @@ export const appendPrivatePrefixTransformers = [
  */
 export const manglePrivatePropertiesOptions = {
   output: {
-    comments: 'all',
+    comments: false,
     beautify: true
   },
   mangle: {

packages/functions/package.json

@@ -32,6 +32,7 @@
     "@firebase/messaging": "0.6.10",
     "rollup": "2.0.6",
     "rollup-plugin-typescript2": "0.26.0",
+    "rollup-plugin-terser": "5.3.0",
     "typescript": "3.8.3"
   },
   "repository": {

packages/functions/rollup.config.js

@@ -19,6 +19,7 @@ import json from 'rollup-plugin-json';
 import typescriptPlugin from 'rollup-plugin-typescript2';
 import typescript from 'typescript';
 import pkg from './package.json';
+import { terser } from 'rollup-plugin-terser';
 
 const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
@@ -31,7 +32,14 @@ const es5BuildPlugins = [
   typescriptPlugin({
     typescript
   }),
-  json()
+  json(),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
+  })
 ];
 
 const es5Builds = [
@@ -67,7 +75,14 @@ const es2017BuildPlugins = [
       }
     }
   }),
-  json({ preferConst: true })
+  json({ preferConst: true }),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
+  })
 ];
 
 /**

packages/installations/package.json

@@ -34,7 +34,7 @@
     "rollup-plugin-json": "4.0.0",
     "rollup-plugin-node-resolve": "5.2.0",
     "rollup-plugin-typescript2": "0.26.0",
-    "rollup-plugin-uglify": "6.0.4",
+    "rollup-plugin-terser": "5.3.0",
     "typescript": "3.8.3"
   },
   "peerDependencies": {

packages/installations/rollup.config.js

@@ -19,13 +19,24 @@ import json from 'rollup-plugin-json';
 import typescriptPlugin from 'rollup-plugin-typescript2';
 import pkg from './package.json';
 import typescript from 'typescript';
+import { terser } from 'rollup-plugin-terser';
 
 const deps = Object.keys({ ...pkg.peerDependencies, ...pkg.dependencies });
 
 /**
  * ES5 Builds
  */
-const es5BuildPlugins = [typescriptPlugin({ typescript }), json()];
+const es5BuildPlugins = [
+  typescriptPlugin({ typescript }), 
+  json(),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
+  })
+];
 
 const es5Builds = [
   {
@@ -51,7 +62,14 @@ const es2017BuildPlugins = [
       }
     }
   }),
-  json({ preferConst: true })
+  json({ preferConst: true }),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
+  })
 ];
 
 const es2017Builds = [

packages/installations/test-app/rollup.config.js

@@ -19,7 +19,7 @@ import typescriptPlugin from 'rollup-plugin-typescript2';
 import resolve from 'rollup-plugin-node-resolve';
 import commonjs from 'rollup-plugin-commonjs';
 import json from 'rollup-plugin-json';
-import { uglify } from 'rollup-plugin-uglify';
+import { terser } from 'rollup-plugin-terser';
 import typescript from 'typescript';
 
 /**
@@ -42,7 +42,7 @@ export default [
       json(),
       resolve(),
       commonjs(),
-      uglify()
+      terser()
     ]
   }
 ];

packages/logger/package.json

@@ -24,6 +24,7 @@
   "devDependencies": {
     "rollup": "2.0.6",
     "rollup-plugin-typescript2": "0.26.0",
+    "rollup-plugin-terser": "5.3.0",
     "typescript": "3.8.3"
   },
   "repository": {

packages/logger/rollup.config.js

@@ -18,13 +18,21 @@
 import typescriptPlugin from 'rollup-plugin-typescript2';
 import typescript from 'typescript';
 import pkg from './package.json';
+import { terser } from 'rollup-plugin-terser';
 
 /**
  * ES5 Builds
  */
 const es5BuildPlugins = [
   typescriptPlugin({
     typescript
+  }),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
   })
 ];
 
@@ -55,6 +63,13 @@ const es2017BuildPlugins = [
         target: 'es2017'
       }
     }
+  }),
+  terser({ // remove comments only, so size presubmit can do code size diff correctly.
+    output: {
+      comments: false
+    },
+    compress: false,
+    mangle: false
   })
 ];
 

packages/messaging/package.json

@@ -36,6 +36,7 @@
   "devDependencies": {
     "rollup": "2.0.6",
     "rollup-plugin-typescript2": "0.26.0",
+    "rollup-plugin-terser": "5.3.0",
     "ts-essentials": "6.0.2",
     "typescript": "3.8.3"
   },