Merge 4998f55 into 7b129c9

Author: Feiyang1

package.json

@@ -122,6 +122,7 @@
     "watch": "1.0.2",
     "webpack": "4.42.0",
     "yargs": "15.3.1",
-    "lodash": "4.17.15"
+    "lodash": "4.17.15",
+    "terser": "4.6.7"
   }
 }

scripts/report_binary_size.js

@@ -2,6 +2,7 @@ const { resolve } = require('path');
 const fs = require('fs');
 const { execSync } = require('child_process');
 const https = require('https');
+const terser = require('terser');
 
 const repoRoot = resolve(__dirname, '..');
 
@@ -58,7 +59,19 @@ function generateReportForNPMPackages() {
         for (const field of fields) {
             if (packageJson[field]) {
                 const filePath = `${package.location}/${packageJson[field]}`;
-                const { size } = fs.statSync(filePath);
+
+                const rawCode = fs.readFileSync(filePath, 'utf-8');
+
+                // remove comments and whitespaces, then get size
+                const { code } = terser.minify(rawCode, {
+                    output: {
+                        comments: false
+                    },
+                    mangle: false,
+                    compress: false
+                });
+
+                const size = Buffer.byteLength(code, 'utf-8')
                 reports.push(makeReportObject(packageJson.name, field, size));
             }
         }

yarn.lock

@@ -13986,19 +13986,10 @@ terser-webpack-plugin@^1.4.3:
     webpack-sources "^1.4.0"
     worker-farm "^1.7.0"
 
-terser@^4.1.2:
-  version "4.3.8"
-  resolved "https://registry.npmjs.org/terser/-/terser-4.3.8.tgz#707f05f3f4c1c70c840e626addfdb1c158a17136"
-  integrity sha512-otmIRlRVmLChAWsnSFNO0Bfk6YySuBp6G9qrHiJwlLDd4mxe2ta4sjI7TzIR+W1nBMjilzrMcPOz9pSusgx3hQ==
-  dependencies:
-    commander "^2.20.0"
-    source-map "~0.6.1"
-    source-map-support "~0.5.12"
-
-terser@^4.6.2:
-  version "4.6.6"
-  resolved "https://registry.npmjs.org/terser/-/terser-4.6.6.tgz#da2382e6cafbdf86205e82fb9a115bd664d54863"
-  integrity sha512-4lYPyeNmstjIIESr/ysHg2vUPRGf2tzF9z2yYwnowXVuVzLEamPN1Gfrz7f8I9uEPuHcbFlW4PLIAsJoxXyJ1g==
+[email protected], terser@^4.1.2, terser@^4.6.2:
+  version "4.6.7"
+  resolved "https://registry.npmjs.org/terser/-/terser-4.6.7.tgz#478d7f9394ec1907f0e488c5f6a6a9a2bad55e72"
+  integrity sha512-fmr7M1f7DBly5cX2+rFDvmGBAaaZyPrHYK4mMdHEDAdNTqXSZgSOfqsfGq2HqPGT/1V0foZZuCZFx8CHKgAk3g==
   dependencies:
     commander "^2.20.0"
     source-map "~0.6.1"