Migrate Auth to component framework #2342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
bojeil-google,
hiranya911,
hsubox76 and
wti806
as code owners
|
@bojeil-google ping |
Feiyang1
force-pushed
the
fei-component-integration
branch
from
bb43a7e to
5e4f80b
Compare
Feiyang1
force-pushed
the
fei-component-auth
branch
from
ef445b5 to
0171cc1
Compare
Feiyang1
force-pushed
the
fei-component-integration
branch
from
292b858 to
9a9bf6f
Compare
Feiyang1
changed the base branch from
fei-component-integration
to
fei-component-integration2
Feiyang1
force-pushed
the
fei-component-auth
branch
from
0171cc1 to
92db586
Compare
Feiyang1
force-pushed
the
fei-component-auth
branch
from
92db586 to
ae2f38e
Compare
bojeil-google
suggested changes
Nov 19, 2019
packages/auth/src/exports_auth.js
Outdated
| } | ||
| ); | ||
|
|
||
| // Create auth components to register with firebase |
There was a problem hiding this comment.
nit: Add dot at the end of the comment
packages/auth/src/exports_auth.js
Outdated
| ); | ||
|
|
||
| // Create auth components to register with firebase | ||
| const authComponent = { // provides Auth public APIs |
There was a problem hiding this comment.
Preferably move comment to newline. Capitalize first letter and add dot to end of line.
// Provides Auth public APIs.
packages/auth/src/exports_auth.js
Outdated
| 'type': 'PUBLIC' | ||
| }; | ||
|
|
||
| const authInteropComponent = { // provides Auth internal APIs |
bojeil-google
approved these changes
Nov 19, 2019
Feiyang1
added a commit
that referenced
this pull request
Nov 22, 2019
* Mirgrate Auth to component framework * update Auth types * [AUTOMATED]: Prettier Code Styling * address comments
Feiyang1
added a commit
that referenced
this pull request
Nov 26, 2019
* Component framework implementation (#2316) * Component implementation * update dep version * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * rename variables * address comments * [AUTOMATED]: Prettier Code Styling * remove unused comment * update code * [AUTOMATED]: Prettier Code Styling * rename to clearInstance to have naming consistency * make FirebaseApp tests work again * fix node tests * [AUTOMATED]: Prettier Code Styling * add comments for ComponentType * [AUTOMATED]: Prettier Code Styling * pass Component directly into Providers * [AUTOMATED]: Prettier Code Styling * correct spellings * update readme * fix lint issue * remove unused import * fix API change * move types around * [AUTOMATED]: Prettier Code Styling * improve provider typing * [AUTOMATED]: Prettier Code Styling * Migrate analytics to component platform (#220) * migrate analytics * minor analytics refactoring * interface merge * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * allow overwriting a registered component * [AUTOMATED]: Prettier Code Styling * change ComponentType to string enum * address comments * [AUTOMATED]: Prettier Code Styling * remove return only generics * Move identifier to options object for getImmediate() * [AUTOMATED]: Prettier Code Styling * Make getProvider() type safe * [AUTOMATED]: Prettier Code Styling * define a new method to replace overwrite flag * [AUTOMATED]: Prettier Code Styling * Make component type safe * [AUTOMATED]: Prettier Code Styling * remove the generic type from component container * Update FirebaseApp and Analytics * [AUTOMATED]: Prettier Code Styling * remove unneccessary casting * [AUTOMATED]: Prettier Code Styling * fix typo * address comments * [AUTOMATED]: Prettier Code Styling * update some types * [AUTOMATED]: Prettier Code Styling * handle errors from instance factory * [AUTOMATED]: Prettier Code Styling * Migrate Performance to component framework (#2325) * Migrate Performance to component framework * [AUTOMATED]: Prettier Code Styling * removed unused import * Migrate RC to component framework (#2324) * Migrate RC to component framework * [AUTOMATED]: Prettier Code Styling * remove unused import * Migrate storage to component framework (#2326) * Migrate Database to component framework (#2327) * Migrate Database to component framework * revert auth formatting * Mirgrate functions to component framework (#2328) * Migrate installations to component framework (#2322) * Migrate installations to component framework * remove unused import * update calling code according to the latest component changes * added forceRefresh back * Migrate messaging to component framework (#2323) * Migrate messaging to component framework * remove unused import * bundle firebase services in a single object * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers * address comment * Make tests work again * Migrate firestore to component framework (#2329) * Migrate Firestore to component framework * [AUTOMATED]: Prettier Code Styling * remove unused import * removed unnecessary type assertion * update getImmeidate call * Migrate testing to component framework * [AUTOMATED]: Prettier Code Styling * Update SDKs to use the new type system (#2358) * update database types * update Firestore types * update installations type * update messaging types * update functions types * update performance types * update remoteconfig types * update storage types * fix analytics issue * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: Prettier Code Styling * Use the new method * Migrate Auth to component framework (#2342) * Mirgrate Auth to component framework * update Auth types * [AUTOMATED]: Prettier Code Styling * address comments * update deps * [AUTOMATED]: Prettier Code Styling * Get installations service from the container (#2376) * Get installations from the container * [AUTOMATED]: Prettier Code Styling * revert dev changes * convert eslint from json to js. * [AUTOMATED]: Prettier Code Styling * fix broken scripts * address comments * [AUTOMATED]: Prettier Code Styling * fix typos
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.