Skip to content

Fixed failed auth tests with component framework #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Nov 7, 2019

Some auth tests failed because it uses firebase.INTERNAL which has been removed.

@Feiyang1 Feiyang1 changed the base branch from fei-component-integration to fei-component-auth November 7, 2019 18:20
@Feiyang1 Feiyang1 changed the base branch from fei-component-auth to fei-component-integration November 7, 2019 18:21
@Feiyang1
Copy link
Member Author

Feiyang1 commented Nov 7, 2019

Merged into #2342

@Feiyang1 Feiyang1 closed this Nov 7, 2019
@Feiyang1 Feiyang1 deleted the fei-component-fix-auth-test branch November 7, 2019 18:28
@firebase firebase locked and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants