Skip to content

Commit 0171cc1

Browse files
committed
define variables at the top of the file
1 parent 5248fc6 commit 0171cc1

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

packages/app-types/index.d.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import { Provider } from '@firebase/component';
2-
31
/**
42
* @license
53
* Copyright 2017 Google Inc.

packages/auth/test/auth_test.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ var appId1 = 'appId1';
7373
var appId2 = 'appId2';
7474
var auth1 = null;
7575
var auth2 = null;
76+
var authInternal1 = null;
77+
var authInternal2 = null;
7678
var app1 = null;
7779
var app2 = null;
7880
var authUi1 = null;
@@ -1014,7 +1016,7 @@ function testGetUid_userSignedIn() {
10141016
// Initialize App and Auth.
10151017
app1 = firebase.initializeApp(config1, appId1);
10161018
auth1 = app1.auth();
1017-
var authInternal1 = app1.container.getProvider('auth-internal').getImmediate();
1019+
authInternal1 = app1.container.getProvider('auth-internal').getImmediate();
10181020
// Initially getUid() should return null;
10191021
assertNull(auth1.getUid());
10201022
assertNull(authInternal1.getUid());
@@ -1066,7 +1068,7 @@ function testGetUid_noUserSignedIn() {
10661068
// Initialize App and Auth.
10671069
app1 = firebase.initializeApp(config1, appId1);
10681070
auth1 = app1.auth();
1069-
var authInternal1 = app1.container.getProvider('auth-internal').getImmediate();
1071+
authInternal1 = app1.container.getProvider('auth-internal').getImmediate();
10701072
// Listen to Auth changes.
10711073
var unsubscribe = auth1.onIdTokenChanged(function(currentUser) {
10721074
// Unsubscribe of Auth state change listener.
@@ -1121,11 +1123,11 @@ function testNotifyAuthListeners() {
11211123
currentUserStorageManager.setCurrentUser(user).then(function() {
11221124
app1 = firebase.initializeApp(config1, appId1);
11231125
auth1 = app1.auth();
1124-
var authInternal1 = app1.container.getProvider('auth-internal').getImmediate();
1126+
authInternal1 = app1.container.getProvider('auth-internal').getImmediate();
11251127
authInternal1.addAuthTokenListener(app1AuthTokenListener);
11261128
app2 = firebase.initializeApp(config2, appId2);
11271129
auth2 = app2.auth();
1128-
var authInternal2 = app2.container.getProvider('auth-internal').getImmediate();
1130+
authInternal2 = app2.container.getProvider('auth-internal').getImmediate();
11291131
authInternal2.addAuthTokenListener(app2AuthTokenListener);
11301132
// Confirm all listeners reset.
11311133
assertEquals(0, listener1.getCallCount());
@@ -1138,7 +1140,6 @@ function testNotifyAuthListeners() {
11381140
auth2.addAuthTokenListener(listener3);
11391141
// Wait for state to be ready on auth1.
11401142
var unsubscribe = auth1.onIdTokenChanged(function(currentUser) {
1141-
console.log('auth1 llllllll', currentUser);
11421143
unsubscribe();
11431144
// Listener 1 and 2 triggered.
11441145
assertEquals(1, listener1.getCallCount());
@@ -1190,7 +1191,6 @@ function testNotifyAuthListeners() {
11901191
});
11911192
// Wait for state to be ready on auth2.
11921193
auth2.onIdTokenChanged(function(currentUser) {
1193-
console.log('auth222222', currentUser);
11941194
// auth2 listener triggered on init with null state once.
11951195
assertEquals(1, listener3.getCallCount());
11961196
assertEquals(
@@ -10205,11 +10205,11 @@ function testAuth_proactiveTokenRefresh_firebaseServiceRemovedAfterSignIn() {
1020510205
auth1 = app1.auth();
1020610206
var subscriber = function(token) {};
1020710207
// Simulate Firebase service added.
10208-
var authInternal = app1.container.getProvider('auth-internal').getImmediate();
10209-
authInternal.addAuthTokenListener(subscriber);
10208+
authInternal1 = app1.container.getProvider('auth-internal').getImmediate();
10209+
authInternal1.addAuthTokenListener(subscriber);
1021010210
// Add same listener again to check that removing it once will ensure the
1021110211
// proactive refresh is stopped.
10212-
authInternal.addAuthTokenListener(subscriber);
10212+
authInternal1.addAuthTokenListener(subscriber);
1021310213
// Simulate user signed in.
1021410214
auth1.signInWithIdTokenResponse(expectedTokenResponse).then(function() {
1021510215
// Current user should be set to user1.
@@ -10221,7 +10221,7 @@ function testAuth_proactiveTokenRefresh_firebaseServiceRemovedAfterSignIn() {
1022110221
assertEquals(
1022210222
0, fireauth.AuthUser.prototype.stopProactiveRefresh.getCallCount());
1022310223
// Simulate Firebase service removed.
10224-
authInternal.removeAuthTokenListener(subscriber);
10224+
authInternal1.removeAuthTokenListener(subscriber);
1022510225
// Confirm proactive refresh stopped on that user.
1022610226
assertEquals(
1022710227
1, fireauth.AuthUser.prototype.stopProactiveRefresh.getCallCount());

0 commit comments

Comments
 (0)