idempotent allocateQuery and notifyLocalViewChanges
#2264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-hui
changed the title
allocateQuery and notifyLocalViewChanges
schmidt-sebastian
approved these changes
Oct 11, 2019
| @@ -812,24 +809,25 @@ export class LocalStore { | |||
| QueryPurpose.Listen, | |||
| txn.currentSequenceNumber | |||
| ); | |||
| return this.queryCache.addQueryData(txn, queryData); | |||
| return this.queryCache.addQueryData(txn, queryData).next(() => { | |||
There was a problem hiding this comment.
I think you can just write this as:
return this.queryCache.addQueryData(txn, queryData).next(() => queryData)
| updatedQueryData | ||
| ); | ||
| } | ||
| } | ||
| return this.persistence.runTransaction( | ||
| 'notifyLocalViewChanges', | ||
| 'readwrite', |
There was a problem hiding this comment.
Here and below: Can you change this to readwrite-idempotent? Note that if you merge in the latest changes from mrschmidt/idempotent, the test runner will automatically run the transaction twice (so you can verify that this works).
wu-hui
commented
Oct 11, 2019
| updatedQueryData | ||
| ); | ||
| } | ||
| } | ||
| return this.persistence.runTransaction( | ||
| 'notifyLocalViewChanges', | ||
| 'readwrite', |
| @@ -812,24 +809,25 @@ export class LocalStore { | |||
| QueryPurpose.Listen, | |||
| txn.currentSequenceNumber | |||
| ); | |||
| return this.queryCache.addQueryData(txn, queryData); | |||
| return this.queryCache.addQueryData(txn, queryData).next(() => { | |||
hsubox76
pushed a commit
that referenced
this pull request
Oct 15, 2019
* Add transaction retries (#2250) * Marking SimpleDb calls as idempotent (#2251) * Mark mostly readonly calls as idempotent (#2252) * Fix test failure (#2256) * Make handleUserChange idempotent (#2257) * Temporarily disable CountingQueryEngine tests (#2258) * Improve test hack (#2259) * Improve test hack * Comment in test hack * Make getNewDocumentChanges() idempotent (#2255) * Add onCommitted listeners for transactions (#2265) * Fix build * Fix Lint * Make applyRemoteEvent idempotent (#2263) * Make notifyLocalViewChanges idempotent (#2268) * Make releaseQuery idempotent (#2266) * Mark acknowledgeBatch and rejectBatch idempotent (#2269) * idempotent `allocateQuery` and `notifyLocalViewChanges` (#2264) * Mark collectGarbage idempotent (#2267) * Idempotency: Address TODOs, add Changelog (#2270)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.