Skip to content

Make handleUserChange idempotent #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2019
Merged

Make handleUserChange idempotent #2257

merged 1 commit into from
Oct 10, 2019

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Oct 10, 2019

No description provided.

schmidt-sebastian
schmidt-sebastian approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this might have been idempotent before, but making it explicit is worthwhile goal. We need to be careful though to never use this.queryEngine within the scope of this transaction.

@wilhuff
Copy link
Contributor Author

wilhuff commented Oct 10, 2019

I ran with the forced rerun and tests related to user changes did fail. The issue is that on the rerun the “old” list is computed from the new mutation queue so the diff becomes empty.

@wilhuff wilhuff merged commit e5c88cd into mrschmidt/idempotent Oct 10, 2019
@wilhuff wilhuff deleted the wilhuff/user-change branch October 11, 2019 03:56
hsubox76 pushed a commit that referenced this pull request Oct 15, 2019
@schmidt-sebastian @hsubox76
Support iOS 13 with offline persistence (#2271)
b21b946 
* Add transaction retries (#2250)

* Marking SimpleDb calls as idempotent (#2251)

* Mark mostly readonly calls as idempotent (#2252)

* Fix test failure (#2256)

* Make handleUserChange idempotent (#2257)

* Temporarily disable CountingQueryEngine tests (#2258)

*  Improve test hack (#2259)

* Improve test hack

* Comment in test hack

* Make getNewDocumentChanges() idempotent (#2255)

* Add onCommitted listeners for transactions (#2265)

* Fix build

* Fix Lint

* Make applyRemoteEvent idempotent (#2263)

* Make notifyLocalViewChanges idempotent (#2268)

* Make releaseQuery idempotent (#2266)

* Mark acknowledgeBatch and rejectBatch idempotent (#2269)

* idempotent `allocateQuery` and `notifyLocalViewChanges` (#2264)

* Mark collectGarbage idempotent (#2267)

* Idempotency: Address TODOs, add Changelog (#2270)
@firebase firebase locked and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@wilhuff wilhuff

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilhuff @schmidt-sebastian