Marking SimpleDb calls as idempotent #2251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
changed the base branch from
mrschmidt/retry
to
mrschmidt/idempotent
wilhuff
approved these changes
Oct 10, 2019
| @@ -184,6 +184,7 @@ async function assertOrdered(paths: ResourcePath[]): Promise<void> { | |||
|
|
|||
| const selected: string[] = []; | |||
| await runTransaction(simpleStore => { | |||
| selected.splice(0); // The function might get re-run. | |||
There was a problem hiding this comment.
This would be cleaner if the selected array were just returned from the transaction.
There was a problem hiding this comment.
That's much cleaner. Updated.
| @@ -329,7 +329,7 @@ export class IndexedDbPersistence implements Persistence { | |||
| }) | |||
| .then(() => { | |||
| return this.simpleDb.runTransaction( | |||
| 'readonly', | |||
| 'readonly-idempotent', | |||
There was a problem hiding this comment.
This appears to modify this.listenSequence in the transaction.
Why not move that out of the transaction and into the first then block below?
There was a problem hiding this comment.
There are a bunch of calls in the SDK that follow this pattern and re-compute a value inside a transaction, but the re-computation has no side effects. In this case, refactoring the change out of this transaction is pretty simple, so I applied the change. It might not always be so simple in other cases though.
hsubox76
pushed a commit
that referenced
this pull request
Oct 15, 2019
* Add transaction retries (#2250) * Marking SimpleDb calls as idempotent (#2251) * Mark mostly readonly calls as idempotent (#2252) * Fix test failure (#2256) * Make handleUserChange idempotent (#2257) * Temporarily disable CountingQueryEngine tests (#2258) * Improve test hack (#2259) * Improve test hack * Comment in test hack * Make getNewDocumentChanges() idempotent (#2255) * Add onCommitted listeners for transactions (#2265) * Fix build * Fix Lint * Make applyRemoteEvent idempotent (#2263) * Make notifyLocalViewChanges idempotent (#2268) * Make releaseQuery idempotent (#2266) * Mark acknowledgeBatch and rejectBatch idempotent (#2269) * idempotent `allocateQuery` and `notifyLocalViewChanges` (#2264) * Mark collectGarbage idempotent (#2267) * Idempotency: Address TODOs, add Changelog (#2270)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks all straightforward calls of SimpleDb.runTransaction as idempotent. Most of the usage is in test.
This was verified via a manual code audit and via a test hack (not checked in) that fails the first run of idempotent transactions.