Propagating the exceptions to the clients. #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fis-exceptions
…into fis-exceptions
ciarand
reviewed
Sep 27, 2019
|
|
||
| @Override | ||
| public boolean onException(PersistedFidEntry persistedFidEntry, Exception exception) { | ||
| if (persistedFidEntry.isErrored()) { |
There was a problem hiding this comment.
when would it be the case that we'd get an exception without the persistedFidEntry being in the error state?
There was a problem hiding this comment.
Interrupted Exception
Exception thrown while persisting.
Thread failure
| new FirebaseInstallationsException( | ||
| "Failed to update client side cache.", | ||
| FirebaseInstallationsException.Status.CLIENT_ERROR)); | ||
| taskCompletionSource.trySetException(exception); |
There was a problem hiding this comment.
given this is the same in each of the listener impls so far we could move it into a default interface method
There was a problem hiding this comment.
error: [NoStaticOrDefaultMethodsInInterfaces] Avoid static/default methods in interfaces: We currently desugar SDKs with retrolambda which has limited support for those.
Default methods require API level 24. Current min is 14
There was a problem hiding this comment.
oh, sad! I thought we had moved past retrolambda
…into fis-exceptions
…into fis-exceptions
…into fis-exceptions
…into fis-exceptions
…into fis-exceptions
|
/test check-changed |
ciarand
approved these changes
Oct 8, 2019
| new FirebaseInstallationsException( | ||
| "Failed to update client side cache.", | ||
| FirebaseInstallationsException.Status.CLIENT_ERROR)); | ||
| taskCompletionSource.trySetException(exception); |
There was a problem hiding this comment.
oh, sad! I thought we had moved past retrolambda
firebase-installations/src/main/java/com/google/firebase/installations/StateListener.java
Show resolved
Hide resolved
…into fis-exceptions
|
/test check-changed |
|
/test api-information |
|
/test new-smoke-tests |
…into fis-exceptions
…into fis-exceptions
|
/retest |
|
/test check-changed |
|
/retest |
ankitaj224
added a commit
that referenced
this pull request
Oct 10, 2019
* Simplifying FirebaseInstallations class by adding listeners. * Addressing ciaran's comments to return same token if multiple getAuthToken() calls are triggered simultaneously. * Cleaning doRegistration method. * Fixing FISClient to correctly parse expiration timestamp. (#848) * Updating getAuthToken to return creation timestamp (#884) * Propagating the exceptions to the clients. (#856)
ankitaj224
added a commit
that referenced
this pull request
Oct 14, 2019
* Implemneting retry for FIS Client. * Simplifying FirebaseInstallations class by adding listeners. (#847) * Simplifying FirebaseInstallations class by adding listeners. * Addressing ciaran's comments to return same token if multiple getAuthToken() calls are triggered simultaneously. * Cleaning doRegistration method. * Fixing FISClient to correctly parse expiration timestamp. (#848) * Updating getAuthToken to return creation timestamp (#884) * Propagating the exceptions to the clients. (#856) * Addressing ciaran's comments. * Merge conflicts. * Nit fixes * Fixing verify format issue.
ankitaj224
added a commit
that referenced
this pull request
Oct 14, 2019
* Fixing FISClient to correctly parse expiration timestamp. (#848) * Updating getAuthToken to return creation timestamp (#884) * Propagating the exceptions to the clients. (#856) * Extract FID from FIS createInstallation response (#888) * Addressing Rayo's comment: Rename PersistedFidEntry to (#899) * Implementing retry once for FIS Client. (#895) * Simplifying FirebaseInstallations class by adding listeners. (#847) * Fixing FISClient to correctly parse expiration timestamp. (#848) * Updating getAuthToken to return creation timestamp (#884) * Propagating the exceptions to the clients. (#856)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.