Extract FID from FIS createInstallation response #888
Conversation
|
/test check-changed |
|
/test new-smoke-tests |
| @@ -117,6 +118,16 @@ | |||
| .setRegistrationStatus(PersistedFid.RegistrationStatus.UNREGISTERED) | |||
| .build(); | |||
|
|
|||
| private static final PersistedFidEntry INVALID_FID_ENTRY = | |||
There was a problem hiding this comment.
I have the feeling we talked about this multiple times already and thus please feel free to ignore:
Why is this not called PersistedInstallationEntry or something.
Since the data stored identifies the Firebase Installation as a whole, i.e. contains the Installation's FID, registration-status, it's Refresh-Token and latest Auth-Token...
Please ignore if we have discussed this already in the past.
I'm also happy to talk in person if you prefer.
There was a problem hiding this comment.
Yes, we have. I acknowledged the comments and changed to PersistedFidEntry. I can change it to 'PersistedInstallationEntry' once more as per your suggestion. But will do that as part of another PR to contain the scope of the current PR.
| .setAuthToken("") | ||
| .setRefreshToken("") | ||
| .setTokenCreationEpochInSecs(TEST_CREATION_TIMESTAMP_1) | ||
| .setExpiresInSecs(0) |
There was a problem hiding this comment.
Assuming that this is an object (or a proto), can we create a class (or proto) for Auth-Token that has the fields "token", "creationTimestamp", "expirationTimestamp" or "expiresIn", so that the fields that belong together are part of the same object?
There was a problem hiding this comment.
I can change but IMO dont see much benefit. This object is used to represent persisted fid & metadata - simpler the class, easier it is to read and write.
Objects that are exposed to users have been separated out into a class (or proto) for Auth-Token & a class for firebase installation. This addresses your comment & is useful to segregate the details to the clients.
|
/retest |
|
/retest |
|
/restest |
|
/retest |
|
/test new-smoke-tests |
|
/test device-check-changed |
* Fixing FISClient to correctly parse expiration timestamp. (#848) * Updating getAuthToken to return creation timestamp (#884) * Propagating the exceptions to the clients. (#856) * Extract FID from FIS createInstallation response (#888) * Addressing Rayo's comment: Rename PersistedFidEntry to (#899) * Implementing retry once for FIS Client. (#895) * Simplifying FirebaseInstallations class by adding listeners. (#847) * Fixing FISClient to correctly parse expiration timestamp. (#848) * Updating getAuthToken to return creation timestamp (#884) * Propagating the exceptions to the clients. (#856)
No description provided.