Simplifying FirebaseInstallations class by adding listeners. (#847)

* Simplifying FirebaseInstallations class by adding listeners.

* Addressing ciaran's comments to return same token if multiple getAuthToken()
calls are triggered simultaneously.

* Cleaning doRegistration method.

* Fixing FISClient to correctly parse expiration timestamp. (#848)

* Updating getAuthToken to return creation timestamp (#884)

* Propagating the exceptions to the clients. (#856)

Author: ankitaj224

firebase-installations-interop/api.txt

@@ -5,15 +5,17 @@ package com.google.firebase.installations {
     ctor public InstallationTokenResult();
     method @NonNull public static com.google.firebase.installations.InstallationTokenResult.Builder builder();
     method @NonNull public abstract String getToken();
-    method @NonNull public abstract long getTokenExpirationInSecs();
+    method @NonNull public abstract long getTokenCreationTimestamp();
+    method @NonNull public abstract long getTokenExpirationTimestamp();
     method @NonNull public abstract com.google.firebase.installations.InstallationTokenResult.Builder toBuilder();
   }
 
   public abstract static class InstallationTokenResult.Builder {
     ctor public InstallationTokenResult.Builder();
     method @NonNull public abstract com.google.firebase.installations.InstallationTokenResult build();
     method @NonNull public abstract com.google.firebase.installations.InstallationTokenResult.Builder setToken(@NonNull String);
-    method @NonNull public abstract com.google.firebase.installations.InstallationTokenResult.Builder setTokenExpirationInSecs(long);
+    method @NonNull public abstract com.google.firebase.installations.InstallationTokenResult.Builder setTokenCreationTimestamp(long);
+    method @NonNull public abstract com.google.firebase.installations.InstallationTokenResult.Builder setTokenExpirationTimestamp(long);
   }
 
 }

firebase-installations-interop/src/main/java/com/google/firebase/installations/InstallationTokenResult.java

@@ -28,7 +28,13 @@ public abstract class InstallationTokenResult {
    * The amount of time, in seconds, before the auth-token expires for this Firebase Installation.
    */
   @NonNull
-  public abstract long getTokenExpirationInSecs();
+  public abstract long getTokenExpirationTimestamp();
+
+  /**
+   * The amount of time, in seconds, when the auth-token was created for this Firebase Installation.
+   */
+  @NonNull
+  public abstract long getTokenCreationTimestamp();
 
   @NonNull
   public abstract Builder toBuilder();
@@ -45,7 +51,10 @@ public abstract static class Builder {
     public abstract Builder setToken(@NonNull String value);
 
     @NonNull
-    public abstract Builder setTokenExpirationInSecs(long value);
+    public abstract Builder setTokenExpirationTimestamp(long value);
+
+    @NonNull
+    public abstract Builder setTokenCreationTimestamp(long value);
 
     @NonNull
     public abstract InstallationTokenResult build();

firebase-installations/api.txt

@@ -29,11 +29,11 @@ package com.google.firebase.installations.local {
     ctor public PersistedFid(@NonNull FirebaseApp);
     method @NonNull public boolean clear();
     method @NonNull public boolean insertOrUpdatePersistedFidEntry(@NonNull com.google.firebase.installations.local.PersistedFidEntry);
-    method @Nullable public com.google.firebase.installations.local.PersistedFidEntry readPersistedFidEntryValue();
+    method @NonNull public com.google.firebase.installations.local.PersistedFidEntry readPersistedFidEntryValue();
   }
 
   public enum PersistedFid.RegistrationStatus {
-    enum_constant public static final com.google.firebase.installations.local.PersistedFid.RegistrationStatus PENDING;
+    enum_constant public static final com.google.firebase.installations.local.PersistedFid.RegistrationStatus NOT_GENERATED;
     enum_constant public static final com.google.firebase.installations.local.PersistedFid.RegistrationStatus REGISTERED;
     enum_constant public static final com.google.firebase.installations.local.PersistedFid.RegistrationStatus REGISTER_ERROR;
     enum_constant public static final com.google.firebase.installations.local.PersistedFid.RegistrationStatus UNREGISTERED;
@@ -44,10 +44,14 @@ package com.google.firebase.installations.local {
     method @NonNull public static com.google.firebase.installations.local.PersistedFidEntry.Builder builder();
     method @Nullable public abstract String getAuthToken();
     method public abstract long getExpiresInSecs();
-    method @NonNull public abstract String getFirebaseInstallationId();
+    method @Nullable public abstract String getFirebaseInstallationId();
     method @Nullable public abstract String getRefreshToken();
     method @NonNull public abstract com.google.firebase.installations.local.PersistedFid.RegistrationStatus getRegistrationStatus();
     method public abstract long getTokenCreationEpochInSecs();
+    method public boolean isErrored();
+    method public boolean isNotGenerated();
+    method public boolean isRegistered();
+    method public boolean isUnregistered();
     method @NonNull public abstract com.google.firebase.installations.local.PersistedFidEntry.Builder toBuilder();
   }
 

firebase-installations/firebase-installations.gradle

@@ -52,6 +52,8 @@ dependencies {
     testImplementation 'androidx.test:core:1.2.0'
     testImplementation 'junit:junit:4.12'
     testImplementation "org.robolectric:robolectric:$robolectricVersion"
+    testImplementation "com.google.truth:truth:$googleTruthVersion"
+
 
     androidTestImplementation 'androidx.test.ext:junit:1.1.1'
     androidTestImplementation 'androidx.test:runner:1.2.0'