Use orphaned docs as part of GC calculation #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| long orphanedDocumentCount = | ||
| persistence | ||
| .query( | ||
| "SELECT COUNT(*) FROM (SELECT sequence_number FROM target_documents GROUP BY path HAVING COUNT(*) = 1 AND target_id = 0)") |
There was a problem hiding this comment.
I don't know SQLite, and I assume you tried "SELECT COUNT() FROM target_documents GROUP BY path HAVING COUNT() = 1 AND target_id = 0"?
There was a problem hiding this comment.
I did indeed try that first. I believe COUNT(*) in the projection interacts poorly with GROUP BY in terms of getting what we want here. Using the subquery technique works, and in retrospect is I think a little more obvious when compared with the similar query used to find the sequence numbers.
schmidt-sebastian
approved these changes
Oct 19, 2018
|
/test smoke-tests-release |
|
/test smoke-tests-debug |
|
/test smoke-tests-release |
1 similar comment
|
/test smoke-tests-release |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had originally decided to only look at targets when assessing how much to run GC. However, based on running a write-heavy workload test, we need to include documents that ended up cached without being part of a target.
This is a port of a portion of firebase/firebase-ios-sdk#1961
Note that merge base is into the LRU branch, not master.
Integration tests pass :)