Skip to content

LRU tweaks #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 17, 2018
Merged

LRU tweaks #1961

merged 6 commits into from
Oct 17, 2018

Conversation

gsoltis
Copy link

@gsoltis gsoltis commented Oct 16, 2018

Merge is into LRU branch.

  • Fixes scheduling to actually work properly!
  • Fixes logging to only use strings because that's all we support
  • Includes orphaned documents in the sequence number count. For some workloads (e.g. write heavy with few targets), just looking at a percentage of targets will avoid GC when it should be running

@gsoltis gsoltis requested a review from wilhuff October 16, 2018 22:44
wilhuff
wilhuff approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned gsoltis and unassigned wilhuff Oct 17, 2018
@gsoltis gsoltis merged commit ba406b6 into gsoltis/lru_gc_disabled Oct 17, 2018
@gsoltis gsoltis deleted the gsoltis/lru_tweaks branch October 17, 2018 23:09
@gsoltis gsoltis mentioned this pull request Oct 18, 2018
Merged
@firebase firebase locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@gsoltis gsoltis

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsoltis @wilhuff @googlebot