Use orphaned docs as part of GC calculation #1355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoltis
requested review from
mikelehen,
rsgowman,
var-const,
wilhuff and
zxu123
as code owners
schmidt-sebastian
approved these changes
Nov 6, 2018
| ): PersistencePromise<number> { | ||
| const docCountPromise = this.orphanedDocmentCount(txn); | ||
| const targetCountPromise = this.db.getQueryCache().getQueryCount(txn); | ||
| return targetCountPromise.next(targetCount => |
There was a problem hiding this comment.
We usually don't include Promise in the name. You can respond to this by just inlining the calls though :)
There was a problem hiding this comment.
I'm going to leave as-is. Inlining would put the operations in sequence, rather than in parallel. Also, the code is dealing with both the promise of the count, and the count itself, so I think it's worthwhile to distinguish them.
| const targetCountPromise = this.persistence | ||
| .getQueryCache() | ||
| .getTargetCount(txn); | ||
| return targetCountPromise.next(targetCount => |
There was a problem hiding this comment.
Same comment regarding the naming as above.
Feiyang1
pushed a commit
that referenced
this pull request
Nov 9, 2018
* Use orphaned documents in sequence number count
zijianjoy
pushed a commit
that referenced
this pull request
May 24, 2019
* Use orphaned documents in sequence number count
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of firebase/firebase-android-sdk#80
We had originally decided to only look at targets when assessing how much to run GC. However, based on running a write-heavy workload test, we need to include documents that ended up cached without being part of a target.