Skip to content

Upgrade to AGP 4.1.0-beta2 + Gradle 6.5.1 for project apk-size. #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2020

Conversation

yifanyang
Copy link
Contributor

This change helps stablize the size of generated APKs.
https://groups.google.com/a/google.com/g/android-gradle-discuss/c/D75NhZpcfBM

@googlebot googlebot added the cla: yes Override cla label Jul 7, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 8, 2020

Coverage Report

Affected SDKs

  • firebase-config

    SDK overall coverage changed from ? (1c84b8e) to 88.72% (52c66841) by ?.

    Click to show coverage changes in 24 files.
    Filename Base (1c84b8e) Head (52c66841) Diff
    Code.java ? 0.00% ?
    ConfigCacheClient.java ? 93.55% ?
    ConfigContainer.java ? 92.16% ?
    ConfigFetchHandler.java ? 97.20% ?
    ConfigFetchHttpClient.java ? 87.30% ?
    ConfigGetParameterHandler.java ? 97.50% ?
    ConfigMetadataClient.java ? 89.47% ?
    ConfigStorageClient.java ? 100.00% ?
    DefaultsXmlParser.java ? 0.00% ?
    FirebaseRemoteConfig.java ? 88.28% ?
    FirebaseRemoteConfigClientException.java ? 100.00% ?
    FirebaseRemoteConfigException.java ? 100.00% ?
    FirebaseRemoteConfigFetchException.java ? 50.00% ?
    FirebaseRemoteConfigFetchThrottledException.java ? 100.00% ?
    FirebaseRemoteConfigInfo.java ? 0.00% ?
    FirebaseRemoteConfigInfoImpl.java ? 100.00% ?
    FirebaseRemoteConfigServerException.java ? 100.00% ?
    FirebaseRemoteConfigSettings.java ? 65.63% ?
    FirebaseRemoteConfigValue.java ? 0.00% ?
    FirebaseRemoteConfigValueImpl.java ? 84.62% ?
    LegacyConfigsHandler.java ? 90.51% ?
    RemoteConfigComponent.java ? 96.36% ?
    RemoteConfigConstants.java ? 0.00% ?
    RemoteConfigRegistrar.java ? 100.00% ?
  • firebase-database

    SDK overall coverage changed from 49.98% (1c84b8e) to 49.95% (52c66841) by -0.02%.

    Filename Base (1c84b8e) Head (52c66841) Diff
    BooleanNode.java 92.31% 100.00% +7.69%
    ChildChangeAccumulator.java 96.77% 83.87% -12.90%
    DoubleNode.java 88.89% 100.00% +11.11%
    ViewProcessor.java 92.35% 92.05% -0.31%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (52c66841) is created by Prow via merging commits: 1c84b8e c7ff5c8.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 8, 2020

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 80.7 kB 97.7 kB +16.9 kB (+21.0%)
    apk (debug) 985 kB 1.10 MB +119 kB (+12.0%)
    apk (release) 880 kB 893 kB +12.5 kB (+1.4%)
  • firebase-common

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 56.0 kB 74.7 kB +18.7 kB (+33.3%)
    apk (debug) 687 kB 776 kB +88.8 kB (+12.9%)
    apk (release) 614 kB 627 kB +13.3 kB (+2.2%)
  • firebase-common-ktx

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 243 kB 90.3 kB -153 kB (-62.9%)
    apk (debug) 1.41 MB 1.39 MB -14.2 kB (-1.0%)
    apk (release) 1.25 MB 1.10 MB -143 kB (-11.5%)
  • firebase-components

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 5.94 kB 8.68 kB +2.74 kB (+46.1%)
    apk (debug) 29.6 kB 35.2 kB +5.58 kB (+18.9%)
    apk (release) 24.6 kB 25.2 kB +592 B (+2.4%)
  • firebase-config

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 179 kB 170 kB -8.87 kB (-5.0%)
    apk (debug) 1.12 MB 1.25 MB +133 kB (+11.9%)
    apk (release) 1.00 MB 1.02 MB +12.8 kB (+1.3%)
  • firebase-config-ktx

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 367 kB 190 kB -177 kB (-48.2%)
    apk (debug) 1.84 MB 1.87 MB +31.3 kB (+1.7%)
    apk (release) 1.64 MB 1.49 MB -144 kB (-8.8%)
  • firebase-crashlytics

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 481 kB 549 kB +68.3 kB (+14.2%)
    apk (debug) 1.37 MB 1.61 MB +245 kB (+17.9%)
    apk (release) 1.25 MB 1.35 MB +98.7 kB (+7.9%)
  • firebase-crashlytics-ktx

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 669 kB 565 kB -104 kB (-15.5%)
    apk (debug) 2.09 MB 2.23 MB +141 kB (+6.7%)
    apk (release) 1.88 MB 1.83 MB -57.9 kB (-3.1%)
  • firebase-crashlytics-ndk

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 1.07 MB 2.03 MB +961 kB (+89.7%)
    apk (debug) 1.96 MB 3.10 MB +1.14 MB (+58.4%)
    apk (release) 1.83 MB 2.83 MB +993 kB (+54.2%)
  • firebase-database

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 206 kB 280 kB +73.1 kB (+35.4%)
    apk (debug) 1.08 MB 1.30 MB +218 kB (+20.2%)
    apk (release) 976 kB 1.08 MB +103 kB (+10.6%)
  • firebase-database-collection

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 195 kB 268 kB +73.4 kB (+37.7%)
    apk (debug) 876 kB 1.07 MB +191 kB (+21.8%)
    apk (release) 796 kB 901 kB +104 kB (+13.1%)
  • firebase-database-ktx

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 394 kB 295 kB -98.8 kB (-25.1%)
    apk (debug) 1.80 MB 1.92 MB +115 kB (+6.4%)
    apk (release) 1.61 MB 1.56 MB -54.4 kB (-3.4%)
  • firebase-datatransport

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 90.3 kB 109 kB +18.9 kB (+20.9%)
    apk (debug) 757 kB 856 kB +99.2 kB (+13.1%)
    apk (release) 677 kB 690 kB +12.5 kB (+1.8%)
  • firebase-decoders-json

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 5.94 kB 8.68 kB +2.74 kB (+46.1%)
    apk (debug) 18.2 kB 22.4 kB +4.15 kB (+22.7%)
    apk (release) 14.7 kB 15.2 kB +555 B (+3.8%)
  • firebase-dynamic-links

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 208 kB 304 kB +95.7 kB (+45.9%)
    apk (debug) 905 kB 1.10 MB +194 kB (+21.5%)
    apk (release) 825 kB 928 kB +103 kB (+12.5%)
  • firebase-dynamic-links-ktx

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 396 kB 320 kB -76.5 kB (-19.3%)
    apk (debug) 1.63 MB 1.72 MB +91.2 kB (+5.6%)
    apk (release) 1.46 MB 1.41 MB -53.7 kB (-3.7%)
  • firebase-encoders-json

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 5.94 kB 8.68 kB +2.74 kB (+46.1%)
    apk (debug) 22.9 kB 27.6 kB +4.72 kB (+20.7%)
    apk (release) 19.1 kB 19.6 kB +531 B (+2.8%)
  • firebase-encoders-reflective

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 5.94 kB 8.68 kB +2.74 kB (+46.1%)
    apk (debug) 25.2 kB 30.3 kB +5.01 kB (+19.9%)
    apk (release) 21.2 kB 21.7 kB +525 B (+2.5%)
  • firebase-firestore

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 343 kB 411 kB +68.1 kB (+19.9%)
    apk (debug) 3.36 MB 3.84 MB +472 kB (+14.0%)
    apk (release) 3.04 MB 3.13 MB +90.7 kB (+3.0%)
  • firebase-firestore-ktx

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 530 kB 426 kB -104 kB (-19.6%)
    apk (debug) 4.09 MB 4.46 MB +372 kB (+9.1%)
    apk (release) 3.68 MB 3.61 MB -67.8 kB (-1.8%)
  • firebase-functions

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 275 kB 347 kB +72.1 kB (+26.2%)
    apk (debug) 1.16 MB 1.37 MB +217 kB (+18.8%)
    apk (release) 1.05 MB 1.16 MB +102 kB (+9.6%)
  • firebase-functions-ktx

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 463 kB 367 kB -95.9 kB (-20.7%)
    apk (debug) 1.88 MB 1.99 MB +113 kB (+6.0%)
    apk (release) 1.69 MB 1.64 MB -55.3 kB (-3.3%)
  • firebase-inappmessaging

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 628 kB 611 kB -16.7 kB (-2.7%)
    apk (debug) 3.68 MB 4.13 MB +445 kB (+12.1%)
    apk (release) 3.29 MB 3.28 MB -2.58 kB (-0.1%)
  • firebase-inappmessaging-display

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) ? 1.42 MB ? (?)
    apk (debug) ? 5.54 MB ? (?)
    apk (release) ? 4.51 MB ? (?)
  • firebase-inappmessaging-display-ktx

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) ? 1.44 MB ? (?)
    apk (debug) ? 6.18 MB ? (?)
    apk (release) ? 5.00 MB ? (?)
  • firebase-inappmessaging-ktx

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 815 kB 626 kB -189 kB (-23.2%)
    apk (debug) 4.41 MB 4.75 MB +341 kB (+7.7%)
    apk (release) 3.93 MB 3.77 MB -160 kB (-4.1%)
  • firebase-installations

    Type Base (1c84b8e) Head (52c66841) Diff
    aar 58.2 kB 58.2 kB +2 B (+0.0%)
    apk (aggressive) 57.7 kB 76.5 kB +18.8 kB (+32.5%)
    apk (debug) 709 kB 800 kB +91.7 kB (+12.9%)
    apk (release) 634 kB 648 kB +13.7 kB (+2.2%)
  • firebase-installations-interop

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 35.0 kB 55.4 kB +20.4 kB (+58.3%)
    apk (debug) 662 kB 748 kB +85.5 kB (+12.9%)
    apk (release) 593 kB 607 kB +14.1 kB (+2.4%)
  • firebase-segmentation

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 605 kB 616 kB +11.0 kB (+1.8%)
    apk (debug) 1.33 MB 1.59 MB +260 kB (+19.6%)
    apk (release) 1.18 MB 1.36 MB +176 kB (+14.8%)
  • firebase-storage

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 206 kB 280 kB +73.2 kB (+35.5%)
    apk (debug) 935 kB 1.13 MB +197 kB (+21.1%)
    apk (release) 850 kB 953 kB +103 kB (+12.1%)
  • firebase-storage-ktx

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 394 kB 295 kB -98.8 kB (-25.1%)
    apk (debug) 1.66 MB 1.75 MB +92.7 kB (+5.6%)
    apk (release) 1.49 MB 1.43 MB -53.9 kB (-3.6%)
  • protolite-well-known-types

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 136 kB 132 kB -3.81 kB (-2.8%)
    apk (debug) 703 kB 773 kB +70.5 kB (+10.0%)
    apk (release) 659 kB 659 kB -220 B (-0.0%)
  • transport-api

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 5.94 kB 8.68 kB +2.74 kB (+46.1%)
    apk (debug) 17.6 kB 21.7 kB +4.14 kB (+23.6%)
    apk (release) 14.3 kB 14.8 kB +547 B (+3.8%)
  • transport-backend-cct

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 43.0 kB 45.6 kB +2.57 kB (+6.0%)
    apk (debug) 89.9 kB 105 kB +15.0 kB (+16.7%)
    apk (release) 81.6 kB 81.3 kB -325 B (-0.4%)
  • transport-runtime

    Type Base (1c84b8e) Head (52c66841) Diff
    apk (aggressive) 30.6 kB 32.9 kB +2.35 kB (+7.7%)
    apk (debug) 70.4 kB 82.5 kB +12.1 kB (+17.2%)
    apk (release) 62.2 kB 62.4 kB +208 B (+0.3%)

Test Logs

Notes

Head commit (52c66841) is created by Prow via merging commits: 1c84b8e c7ff5c8.

@yifanyang
Copy link
Contributor Author

/test device-check-changed

* com.google.firebase.installations.FirebaseInstallations#delete()}. Sending a Fetch request after
* deletion will create a new installation ID for this Firebase installation and resume the
* com.google.firebase.installations.FirebaseInstallations#delete()}. Sending a Fetch request
* after deletion will create a new installation ID for this Firebase installation and resume the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the formatting issue in #1761 (comment).

@yifanyang yifanyang requested review from rlazo and vkryachko July 8, 2020 01:43
@yifanyang yifanyang merged commit be99c93 into master Jul 8, 2020
@yifanyang yifanyang deleted the yifany/apk-size branch July 8, 2020 03:45
@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants