Skip to content

Repack apk files into zip format to generate stable size measurements. #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2020
Merged

Repack apk files into zip format to generate stable size measurements. #1719

merged 1 commit into from
Jun 29, 2020

Conversation

yifanyang
Copy link
Contributor

No description provided.

@yifanyang yifanyang requested review from vkryachko and rlazo June 25, 2020 23:01
@googlebot googlebot added the cla: yes Override cla label Jun 25, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 49.97% (93cdb04) to 50.00% (cca5de3e) by +0.03%.

    Filename Base (93cdb04) Head (cca5de3e) Diff
    ChildChangeAccumulator.java 83.87% 96.77% +12.90%
    ViewProcessor.java 92.35% 92.05% -0.31%

  • firebase-storage

    SDK overall coverage changed from 85.44% (93cdb04) to 85.48% (cca5de3e) by +0.04%.

    Filename Base (93cdb04) Head (cca5de3e) Diff
    UploadTask.java 79.85% 80.22% +0.37%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (cca5de3e) is created by Prow via merging commits: 93cdb04 17c4645.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 107 kB 80.7 kB -26.2 kB (-24.5%)
    apk (debug) 1.10 MB 985 kB -110 kB (-10.1%)
    apk (release) 903 kB 880 kB -22.2 kB (-2.5%)

  • firebase-common

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 82.7 kB 56.0 kB -26.7 kB (-32.3%)
    apk (debug) 772 kB 687 kB -84.7 kB (-11.0%)
    apk (release) 637 kB 614 kB -23.0 kB (-3.6%)

  • firebase-common-ktx

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 272 kB 243 kB -28.7 kB (-10.5%)
    apk (debug) 1.56 MB 1.41 MB -150 kB (-9.6%)
    apk (release) 1.27 MB 1.25 MB -19.5 kB (-1.5%)

  • firebase-components

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 11.0 kB 5.95 kB -5.01 kB (-45.7%)
    apk (debug) 35.9 kB 29.6 kB -6.27 kB (-17.5%)
    apk (release) 25.4 kB 24.6 kB -842 B (-3.3%)

  • firebase-config

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 207 kB 179 kB -27.8 kB (-13.4%)
    apk (debug) 1.24 MB 1.12 MB -124 kB (-10.0%)
    apk (release) 1.03 MB 1.00 MB -24.4 kB (-2.4%)

  • firebase-config-ktx

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 396 kB 367 kB -29.8 kB (-7.5%)
    apk (debug) 2.03 MB 1.84 MB -188 kB (-9.3%)
    apk (release) 1.66 MB 1.64 MB -20.4 kB (-1.2%)

  • firebase-crashlytics

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 599 kB 481 kB -118 kB (-19.7%)
    apk (debug) 1.60 MB 1.37 MB -232 kB (-14.5%)
    apk (release) 1.36 MB 1.25 MB -115 kB (-8.5%)

  • firebase-crashlytics-ktx

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 789 kB 669 kB -120 kB (-15.2%)
    apk (debug) 2.39 MB 2.09 MB -296 kB (-12.4%)
    apk (release) 2.00 MB 1.88 MB -112 kB (-5.6%)

  • firebase-crashlytics-ndk

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 1.19 MB 1.07 MB -116 kB (-9.8%)
    apk (debug) 2.23 MB 1.96 MB -278 kB (-12.5%)
    apk (release) 1.95 MB 1.83 MB -113 kB (-5.8%)

  • firebase-database

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 326 kB 206 kB -119 kB (-36.6%)
    apk (debug) 1.29 MB 1.08 MB -210 kB (-16.3%)
    apk (release) 1.09 MB 976 kB -117 kB (-10.7%)

  • firebase-database-collection

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 314 kB 195 kB -119 kB (-38.0%)
    apk (debug) 1.07 MB 876 kB -191 kB (-17.9%)
    apk (release) 913 kB 796 kB -117 kB (-12.8%)

  • firebase-database-ktx

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 515 kB 394 kB -121 kB (-23.5%)
    apk (debug) 2.08 MB 1.80 MB -275 kB (-13.2%)
    apk (release) 1.73 MB 1.61 MB -113 kB (-6.6%)

  • firebase-datatransport

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 117 kB 90.3 kB -26.6 kB (-22.8%)
    apk (debug) 848 kB 757 kB -91.0 kB (-10.7%)
    apk (release) 700 kB 677 kB -23.0 kB (-3.3%)

  • firebase-decoders-json

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 11.0 kB 5.95 kB -5.01 kB (-45.7%)
    apk (debug) 23.7 kB 18.2 kB -5.41 kB (-22.9%)
    apk (release) 15.5 kB 14.7 kB -812 B (-5.2%)

  • firebase-dynamic-links

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 328 kB 208 kB -119 kB (-36.4%)
    apk (debug) 1.10 MB 905 kB -194 kB (-17.6%)
    apk (release) 942 kB 825 kB -117 kB (-12.4%)

  • firebase-dynamic-links-ktx

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 518 kB 396 kB -121 kB (-23.4%)
    apk (debug) 1.89 MB 1.63 MB -258 kB (-13.7%)
    apk (release) 1.58 MB 1.46 MB -114 kB (-7.2%)

  • firebase-encoders-json

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 11.0 kB 5.95 kB -5.01 kB (-45.7%)
    apk (debug) 28.6 kB 22.9 kB -5.72 kB (-20.0%)
    apk (release) 19.9 kB 19.1 kB -837 B (-4.2%)

  • firebase-encoders-reflective

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 11.0 kB 5.95 kB -5.01 kB (-45.7%)
    apk (debug) 31.1 kB 25.2 kB -5.89 kB (-18.9%)
    apk (release) 22.0 kB 21.2 kB -839 B (-3.8%)

  • firebase-firestore

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 461 kB 343 kB -119 kB (-25.7%)
    apk (debug) 3.79 MB 3.36 MB -424 kB (-11.2%)
    apk (release) 3.16 MB 3.04 MB -112 kB (-3.5%)

  • firebase-firestore-ktx

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 651 kB 530 kB -121 kB (-18.5%)
    apk (debug) 4.58 MB 4.09 MB -490 kB (-10.7%)
    apk (release) 3.79 MB 3.68 MB -104 kB (-2.8%)

  • firebase-functions

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 394 kB 275 kB -119 kB (-30.2%)
    apk (debug) 1.37 MB 1.16 MB -212 kB (-15.5%)
    apk (release) 1.17 MB 1.05 MB -116 kB (-9.9%)

  • firebase-functions-ktx

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 583 kB 463 kB -121 kB (-20.7%)
    apk (debug) 2.16 MB 1.88 MB -275 kB (-12.8%)
    apk (release) 1.80 MB 1.69 MB -112 kB (-6.2%)

  • firebase-inappmessaging

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 654 kB 628 kB -26.0 kB (-4.0%)
    apk (debug) 4.05 MB 3.68 MB -366 kB (-9.0%)
    apk (release) 3.30 MB 3.29 MB -16.2 kB (-0.5%)

  • firebase-inappmessaging-ktx

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 843 kB 815 kB -28.0 kB (-3.3%)
    apk (debug) 4.84 MB 4.41 MB -432 kB (-8.9%)
    apk (release) 3.94 MB 3.93 MB -10.5 kB (-0.3%)

  • firebase-installations

    Type Base (93cdb04) Head (cca5de3e) Diff
    aar 58.2 kB 58.2 kB +8 B (+0.0%)
    apk (aggressive) 84.4 kB 57.7 kB -26.7 kB (-31.6%)
    apk (debug) 796 kB 709 kB -87.1 kB (-10.9%)
    apk (release) 657 kB 634 kB -23.2 kB (-3.5%)

  • firebase-installations-interop

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 61.7 kB 35.0 kB -26.7 kB (-43.3%)
    apk (debug) 744 kB 662 kB -82.0 kB (-11.0%)
    apk (release) 616 kB 593 kB -23.2 kB (-3.8%)

  • firebase-segmentation

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 802 kB 605 kB -197 kB (-24.5%)
    apk (debug) 1.61 MB 1.33 MB -287 kB (-17.8%)
    apk (release) 1.38 MB 1.18 MB -192 kB (-13.9%)

  • firebase-storage

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 326 kB 206 kB -119 kB (-36.6%)
    apk (debug) 1.13 MB 935 kB -195 kB (-17.2%)
    apk (release) 967 kB 850 kB -117 kB (-12.1%)

  • firebase-storage-ktx

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 515 kB 394 kB -121 kB (-23.5%)
    apk (debug) 1.92 MB 1.66 MB -259 kB (-13.5%)
    apk (release) 1.60 MB 1.49 MB -113 kB (-7.1%)

  • protolite-well-known-types

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 140 kB 136 kB -4.60 kB (-3.3%)
    apk (debug) 768 kB 703 kB -65.4 kB (-8.5%)
    apk (release) 657 kB 659 kB +1.95 kB (+0.3%)

  • transport-api

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 11.0 kB 5.95 kB -5.01 kB (-45.7%)
    apk (debug) 23.0 kB 17.6 kB -5.38 kB (-23.4%)
    apk (release) 15.1 kB 14.3 kB -804 B (-5.3%)

  • transport-backend-cct

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 48.0 kB 43.0 kB -4.96 kB (-10.3%)
    apk (debug) 102 kB 89.9 kB -12.1 kB (-11.9%)
    apk (release) 82.4 kB 81.6 kB -764 B (-0.9%)

  • transport-runtime

    Type Base (93cdb04) Head (cca5de3e) Diff
    apk (aggressive) 35.6 kB 30.6 kB -4.96 kB (-13.9%)
    apk (debug) 80.6 kB 70.4 kB -10.2 kB (-12.6%)
    apk (release) 62.9 kB 62.2 kB -734 B (-1.2%)

Test Logs

Notes

Head commit (cca5de3e) is created by Prow via merging commits: 93cdb04 17c4645.

vkryachko
vkryachko reviewed Jun 29, 2020
View reviewed changes
apk-size/apk-size.gradle
@@ -24,6 +24,10 @@ buildscript {
}
}

plugins {
id "com.dorongold.task-tree" version "1.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this plugin for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/dorongold/gradle-task-tree

This is used to print out a tree of task dependencies. It is added to the apk-size project only. The main project will not be affected.

@yifanyang yifanyang merged commit 3c9f431 into master Jun 29, 2020
@yifanyang yifanyang deleted the yifany/apk-size branch June 29, 2020 17:47
yifanyang added a commit that referenced this pull request Jul 7, 2020
@yifanyang
Revert "Repack apk files into zip format to generate stable size meas…
ba523b2 
…urements. (#1719)"

This reverts commit 3c9f431.
yifanyang added a commit that referenced this pull request Jul 8, 2020
@yifanyang
Revert "Repack apk files into zip format to generate stable size meas…
7be1ed3 
…urements. (#1719)"

This reverts commit 3c9f431.
@firebase firebase locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yifanyang @google-oss-bot @vkryachko @rlazo @googlebot