Skip to content

Add missing parenthesis to link. #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2020
Merged

Add missing parenthesis to link. #1761

merged 2 commits into from
Jul 7, 2020

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jul 6, 2020

Without the parenthesis, the link is broken.

@googlebot googlebot added the cla: yes Override cla label Jul 6, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 6, 2020 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (bc666db) and head commit (92d44b2b).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (92d44b2b) is created by Prow via merging commits: bc666db 9a1ccae.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 6, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (bc666db) Head (92d44b2b) Diff
    apk (aggressive) 80.7 kB 80.7 kB +1 B (+0.0%)

  • firebase-common

    Type Base (bc666db) Head (92d44b2b) Diff
    apk (aggressive) 56.0 kB 56.0 kB +2 B (+0.0%)
    apk (debug) 687 kB 687 kB -3 B (-0.0%)

  • firebase-components

    Type Base (bc666db) Head (92d44b2b) Diff
    apk (aggressive) 5.94 kB 5.95 kB +2 B (+0.0%)
    apk (debug) 29.6 kB 29.6 kB +4 B (+0.0%)

  • firebase-config

    Type Base (bc666db) Head (92d44b2b) Diff
    apk (debug) 1.12 MB 1.12 MB -2 B (-0.0%)

  • firebase-installations

    Type Base (bc666db) Head (92d44b2b) Diff
    aar 58.2 kB 58.2 kB +10 B (+0.0%)

  • firebase-installations-interop

    Type Base (bc666db) Head (92d44b2b) Diff
    apk (aggressive) 35.0 kB 35.0 kB +1 B (+0.0%)
    apk (debug) 662 kB 662 kB -1 B (-0.0%)

Test Logs

Notes

Head commit (92d44b2b) is created by Prow via merging commits: bc666db 9a1ccae.

@google-oss-bot
Copy link
Contributor

@rlazo: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 9a1ccae link /test check-changed
smoke-tests 9a1ccae link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo rlazo merged commit 1c84b8e into master Jul 7, 2020
@rlazo rlazo deleted the rl.rcdoc branch July 7, 2020 10:51
@yifanyang yifanyang mentioned this pull request Jul 8, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danasilver danasilver danasilver approved these changes

@andirayo andirayo andirayo approved these changes

@rachelsaunders rachelsaunders rachelsaunders approved these changes

@ashwinraghav ashwinraghav Awaiting requested review from ashwinraghav

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rlazo @google-oss-bot @danasilver @andirayo @rachelsaunders @googlebot