Skip to content

re-generate rtdb's api.txt and fail build if an error occurs parsing the file #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 19, 2020

Conversation

thatfiredev
Copy link
Member

The api.txt file should have been regenerated in #1672, but the build failed silently with a warning:

Unable to parse signature file /home/prow/go/src/github.com/firebase/firebase-android-sdk/firebase-database/api.txt:

 /home/prow/go/src/github.com/firebase/firebase-android-sdk/firebase-database/api.txt:191:

 expected ; found (

This PR should:

  • unset setIgnoreExitValue(true) to prevent the build from failing silently;
  • regenerate the firebase-database's api.txt file.

@googlebot googlebot added the cla: yes Override cla label Jun 19, 2020
@google-oss-bot
Copy link
Contributor

Hi @rosariopfernandes. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thatfiredev thatfiredev changed the base branch from master to ss-firestore-emulator-settings June 19, 2020 19:48
@samtstern
Copy link
Contributor

@rosariopfernandes didn't realize you were already working on this! No need to base this on my PR, you can base this on master. This change is good.

You can just copy the @hide comment from #1690 (just pushed it)

@thatfiredev
Copy link
Member Author

@samtstern Seems like I was also seeing an outdated thread and I only saw the recent comments when I posted mine.

I'll base this on master and add the @hide comment

@thatfiredev thatfiredev changed the base branch from ss-firestore-emulator-settings to master June 19, 2020 19:52
@samtstern samtstern requested a review from rlazo June 19, 2020 20:20
@samtstern
Copy link
Contributor

Just gonna have @rlazo double-check this because I am not a normal SDK approver, although this LGTM!

@rlazo
Copy link
Collaborator

rlazo commented Jun 19, 2020

Done, thanks!

@rlazo rlazo merged commit d6cca79 into firebase:master Jun 19, 2020
@thatfiredev thatfiredev deleted the rpf-fix-api-txt-file-validation branch June 19, 2020 21:10
@firebase firebase locked and limited conversation to collaborators Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants