-
Notifications
You must be signed in to change notification settings - Fork 615
re-generate rtdb's api.txt and fail build if an error occurs parsing the file #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-generate rtdb's api.txt and fail build if an error occurs parsing the file #1692
Conversation
Hi @rosariopfernandes. Thanks for your PR. I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…irebase/firebase-android-sdk into rpf-fix-api-txt-file-validation
@rosariopfernandes didn't realize you were already working on this! No need to base this on my PR, you can base this on You can just copy the |
@samtstern Seems like I was also seeing an outdated thread and I only saw the recent comments when I posted mine. I'll base this on master and add the |
firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java
Outdated
Show resolved
Hide resolved
Just gonna have @rlazo double-check this because I am not a normal SDK approver, although this LGTM! |
Done, thanks! |
The api.txt file should have been regenerated in #1672, but the build failed silently with a warning:
This PR should:
setIgnoreExitValue(true)
to prevent the build from failing silently;