Skip to content

Functions unified emulator settings #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2020
Merged

Functions unified emulator settings #1688

merged 3 commits into from
Jun 19, 2020

Conversation

samtstern
Copy link
Contributor

Follow up to #1672 but for FirebaseFunctions

@googlebot googlebot added the cla: yes Override cla label Jun 19, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 19, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (874cca0) Head (209bf024) Diff
    apk (aggressive) 82.7 kB 82.7 kB +14 B (+0.0%)
    apk (debug) 772 kB 771 kB -79 B (-0.0%)

  • firebase-components

    Type Base (874cca0) Head (209bf024) Diff
    apk (aggressive) 11.0 kB 11.0 kB -7 B (-0.1%)
    apk (debug) 35.9 kB 35.8 kB -31 B (-0.1%)

  • firebase-functions

    Type Base (874cca0) Head (209bf024) Diff
    aar 25.9 kB 26.4 kB +508 B (+2.0%)
    apk (aggressive) 394 kB 394 kB -32 B (-0.0%)
    apk (debug) 1.37 MB 1.37 MB +43 B (+0.0%)
    apk (release) 1.17 MB 1.17 MB +138 B (+0.0%)

Test Logs

Notes

Head commit (209bf024) is created by Prow via merging commits: 874cca0 5d3a9e8.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 19, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-functions

    SDK overall coverage changed from 3.78% (874cca0) to 3.70% (209bf024) by -0.08%.

    Filename Base (874cca0) Head (209bf024) Diff

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (209bf024) is created by Prow via merging commits: 874cca0 5d3a9e8.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-functions:
error: Method com.google.firebase.functions.FirebaseFunctions.useFunctionsEmulator has changed deprecation state false --> true [ChangedDeprecated]
error: Added field com.google.firebase.functions.FirebaseFunctions.EMULATOR [AddedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@samtstern samtstern requested a review from davidmotson June 19, 2020 16:03
davidmotson
davidmotson approved these changes Jun 19, 2020
View reviewed changes
@samtstern samtstern merged commit caebf44 into master Jun 19, 2020
@samtstern samtstern mentioned this pull request Jun 24, 2020
Merged
2 tasks
@firebase firebase locked and limited conversation to collaborators Jul 20, 2020
@kaibolay kaibolay deleted the ss-functions-emulator-settings branch September 14, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thatfiredev thatfiredev thatfiredev left review comments

@davidmotson davidmotson davidmotson approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samtstern @google-oss-bot @davidmotson @thatfiredev @googlebot