Skip to content

chore(fiam + fiamd): re-generate api.txt files #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented Jun 22, 2020

After the CI fix implemented in #1692 , the build in new PRs is failing because the current api.txt files from in-app-messaging and in-app-messaging-display are outdated:

> Task :firebase-inappmessaging:apiInformation FAILED
Aborting: Your changes have resulted in differences in the signature file
for the public API.
The changes may be compatible, but the signature file needs to be updated.
Diffs:
--- /home/prow/go/src/github.com/firebase/firebase-android-sdk/firebase-inappmessaging/api.txt	2020-06-22 16:47:15.984360721 +0000
+++ /home/prow/go/src/github.com/firebase/firebase-android-sdk/build/apiinfo/firebase-inappmessaging_api.txt	2020-06-22 16:52:35.872100325 +0000
@@ -18,7 +18,7 @@
     method public void setAutomaticDataCollectionEnabled(boolean);
     method public void setMessageDisplayComponent(@NonNull com.google.firebase.inappmessaging.FirebaseInAppMessagingDisplay);
     method public void setMessagesSuppressed(@NonNull Boolean);
-    method public void triggerEvent(String);
+    method public void triggerEvent(@NonNull String);
   }

This PR should fix these files so that they can be parsed properly.

cc: @rlazo @JasonAHeron

@google-oss-bot
Copy link
Contributor

Hi @rosariopfernandes. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@samtstern
Copy link
Contributor

/ok-to-test

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (d6cca79) and head commit (e454c540).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (e454c540) is created by Prow via merging commits: d6cca79 10d0a9b.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (d6cca79) Head (e454c540) Diff
    apk (aggressive) 85.5 kB 85.5 kB +7 B (+0.0%)
    apk (debug) 895 kB 895 kB +34 B (+0.0%)
  • firebase-common

    Type Base (d6cca79) Head (e454c540) Diff
    apk (aggressive) 82.7 kB 82.7 kB -6 B (-0.0%)
    apk (debug) 772 kB 772 kB +38 B (+0.0%)
  • firebase-components

    Type Base (d6cca79) Head (e454c540) Diff
    apk (aggressive) 11.0 kB 11.0 kB +11 B (+0.1%)
    apk (debug) 35.8 kB 35.9 kB +26 B (+0.1%)
  • firebase-datatransport

    Type Base (d6cca79) Head (e454c540) Diff
    apk (aggressive) 117 kB 117 kB -10 B (-0.0%)
    apk (debug) 848 kB 848 kB +63 B (+0.0%)
  • firebase-encoders-json

    Type Base (d6cca79) Head (e454c540) Diff
    apk (aggressive) 11.0 kB 11.0 kB +11 B (+0.1%)
    apk (debug) 28.6 kB 28.6 kB -1 B (-0.0%)
  • firebase-inappmessaging

    Type Base (d6cca79) Head (e454c540) Diff
    apk (aggressive) 610 kB 610 kB +15 B (+0.0%)
    apk (debug) 4.02 MB 4.02 MB +17 B (+0.0%)
  • firebase-installations

    Type Base (d6cca79) Head (e454c540) Diff
    aar 58.1 kB 58.1 kB +1 B (+0.0%)
    apk (aggressive) 84.4 kB 84.4 kB +21 B (+0.0%)
    apk (debug) 796 kB 795 kB -47 B (-0.0%)
  • firebase-installations-interop

    Type Base (d6cca79) Head (e454c540) Diff
    apk (aggressive) 61.7 kB 61.7 kB -11 B (-0.0%)
    apk (debug) 744 kB 744 kB -50 B (-0.0%)
  • protolite-well-known-types

    Type Base (d6cca79) Head (e454c540) Diff
    apk (aggressive) 122 kB 122 kB -10 B (-0.0%)
    apk (debug) 643 kB 643 kB +4 B (+0.0%)
  • transport-api

    Type Base (d6cca79) Head (e454c540) Diff
    apk (aggressive) 11.0 kB 11.0 kB +11 B (+0.1%)
    apk (debug) 23.0 kB 23.0 kB +4 B (+0.0%)
  • transport-backend-cct

    Type Base (d6cca79) Head (e454c540) Diff
    apk (aggressive) 47.9 kB 47.9 kB -2 B (-0.0%)
    apk (debug) 102 kB 102 kB -29 B (-0.0%)
  • transport-runtime

    Type Base (d6cca79) Head (e454c540) Diff
    apk (aggressive) 35.6 kB 35.6 kB -2 B (-0.0%)
    apk (debug) 80.6 kB 80.6 kB +12 B (+0.0%)

Test Logs

Notes

Head commit (e454c540) is created by Prow via merging commits: d6cca79 10d0a9b.

@rlazo rlazo self-requested a review June 22, 2020 19:48
@rlazo
Copy link
Collaborator

rlazo commented Jun 22, 2020

Thanks a lot for the fix @rosariopfernandes ! Approved

@rlazo rlazo merged commit 5e452a9 into firebase:master Jun 22, 2020
@thatfiredev thatfiredev deleted the rpf-regenerate-fiam-api.txt-files branch June 22, 2020 21:06
@firebase firebase locked and limited conversation to collaborators Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants