Pass the iid token to authenticate Instance-ID migration to FIS. #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts for it. (#524) * Add type arguments in StorageTaskManager (#517) * Output artifact list during local publishing. (#515) This effort replaces #494. * Implement Firebase segmentation SDK device local cache * fix functions (#523) * fix functions * update minsdk version * remove idea * Set test type to release only in CI. (#522) * Set test type to release only in CI. This fixes Android Studio issue, where it is impossible to run integration tests in debug mode. Additionally move build type configuration to FirebaseLibraryPlugin to avoid projects.all configuration in gradle. * Add comment back. * [Firebase Segmentation] Add custom installation id cache layer and tests for it. * Add test for updating cache * Switch to use SQLiteOpenHelper * Minor fix to error message to match the admin sdk. (#525) * Minor fix to error message to match the admin sdk. In particular, it *is* allowed to have slashes, etc in field paths. * Added clean task to smoke tests. (#527) This change allows the smoke tests to clean all build variants created by the infrastructure. * Update deps to post-androidx gms versions. (#526) * Update deps to post-androidx gms versions. Additionally configure sources.jar for SDKs. * Update functions-ktx deps * Fix versions. * unbump fiam version in fiamui-app * Switch to use SharedPreferences from SQLite. * Change the cache class to be singleton * Copy firebase-firestore-ktx dependencies on firestore into its own subfolder (#528) * Wrap shared pref commit in a async task. * Address comments * Bump firestore version for release (#530) Additionally fix pom filter to exclude multidex from deps. * Google format fix
* Implement Firebase segmentation SDK device local cache * [Firebase Segmentation] Add custom installation id cache layer and tests for it. * Add test for updating cache * Switch to use SQLiteOpenHelper * Switch to use SharedPreferences from SQLite. * Change the cache class to be singleton * Wrap shared pref commit in a async task. * Address comments * Google format fix * Replace some deprecated code.
* Implement Firebase segmentation SDK device local cache * [Firebase Segmentation] Add custom installation id cache layer and tests for it. * Add test for updating cache * Switch to use SQLiteOpenHelper * Switch to use SharedPreferences from SQLite. * Change the cache class to be singleton * Wrap shared pref commit in a async task. * Address comments * Google format fix * Replace some deprecated code. * Package refactor * nit * nit
cache and update to Firebase Segmentation backend. CL also contains unit tests. (The http client is not implemented yet.)
* Switch from using SharedPreferences to a flat file * Fixes for multi-process access - switch from shared prefs to a flat file - protect generate Fid for cross-process and cross-thread accesses - make doRegistration only read the prefs once at the beginning and clean up the flow - pass the forceRefresh flag into doRegistration rather than storing it in a global * revert the name of the FID prefs write call * fix formatting issues * Fix the cross process locking The check if a new FID was needed was not in the critical region. * some small changes from the review * fix the java format and update the api file
* changed the instrumentation tests into unit tests unit tests are easier and faster to run and debug the unit tests are also included in the code coverage tests * remove the FirebaseInstallations instrumentation tests These have been moved into unit tests and so are no longer needed. Also removed constants that are no longer referenced. * fix a format error
An intermediate RandomAccessFile created while acquiring the lock was not closed. Also pulled the cross process locking logic out into a separate class.
Codecov Report
@@ Coverage Diff @@
## master #1099 +/- ##
============================================
+ Coverage 58.39% 58.42% +0.02%
- Complexity 6325 6327 +2
============================================
Files 640 640
Lines 31401 31404 +3
Branches 4330 4331 +1
============================================
+ Hits 18338 18349 +11
+ Misses 11609 11602 -7
+ Partials 1454 1453 -1
Continue to review full report at Codecov.
|
andirayo
approved these changes
Jan 8, 2020
| @@ -90,6 +90,8 @@ | |||
|
|
|||
| public static final String TEST_INSTANCE_ID_1 = "ccccccccccc"; | |||
|
|
|||
| public static final String TEST_INSTANCE_ID_TOKEN_1 = "iid.token"; | |||
| // Note: Default value of instanceIdMigrationAuth: null | ||
| String iidToken = null; | ||
|
|
||
| if (prefs.getFirebaseInstallationId().equals(iidStore.readIid())) { |
There was a problem hiding this comment.
Isn't reading from iidStore a complicated action?
Maybe checking the length of the identifier (e.g. == 11) is enough?
But in the end I don't care, just sharing my thoughts.
fredquintana
approved these changes
Jan 8, 2020
ankitaj224
added a commit
that referenced
this pull request
Jan 8, 2020
ankitaj224
added a commit
that referenced
this pull request
Jan 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.