Output artifact list during local publishing. #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonbm92
force-pushed
the
allison-publish-list
branch
3 times, most recently
from
fc6c8fc to
dc3c3ed
Compare
vkryachko
reviewed
Jun 12, 2019
buildSrc/src/main/groovy/com/google/firebase/gradle/plugins/publish/PublishingPlugin.groovy
Outdated
Show resolved
Hide resolved
vkryachko
reviewed
Jun 12, 2019
buildSrc/src/main/groovy/com/google/firebase/gradle/plugins/publish/PublishingPlugin.groovy
Outdated
Show resolved
Hide resolved
allisonbm92
force-pushed
the
allison-publish-list
branch
from
dc3c3ed to
8c65245
Compare
vkryachko
reviewed
Jun 12, 2019
There was a problem hiding this comment.
Thinking out loud.
Do you mind extracting all this logic into a dedicated plugin to keep plugins cohesive? As we've historically had problems with putting too much unrelated code into plugins, making them harder to test and maintain.
Additionally I think it makes sense to have the json file generated only if requested on the command line explicitly, e.g. smoke tests could run
./gradlew generateChangedArtifactNames publishAllToBuildDir
wdyt?
This effort replaces #494.
allisonbm92
force-pushed
the
allison-publish-list
branch
from
8c65245 to
6afd1e8
Compare
|
@vkryachko PTAL |
vkryachko
approved these changes
Jun 13, 2019
diwu-arete
added a commit
that referenced
this pull request
Jun 18, 2019
…sts for it. (#524) * Add type arguments in StorageTaskManager (#517) * Output artifact list during local publishing. (#515) This effort replaces #494. * Implement Firebase segmentation SDK device local cache * fix functions (#523) * fix functions * update minsdk version * remove idea * Set test type to release only in CI. (#522) * Set test type to release only in CI. This fixes Android Studio issue, where it is impossible to run integration tests in debug mode. Additionally move build type configuration to FirebaseLibraryPlugin to avoid projects.all configuration in gradle. * Add comment back. * [Firebase Segmentation] Add custom installation id cache layer and tests for it. * Add test for updating cache * Switch to use SQLiteOpenHelper * Minor fix to error message to match the admin sdk. (#525) * Minor fix to error message to match the admin sdk. In particular, it *is* allowed to have slashes, etc in field paths. * Added clean task to smoke tests. (#527) This change allows the smoke tests to clean all build variants created by the infrastructure. * Update deps to post-androidx gms versions. (#526) * Update deps to post-androidx gms versions. Additionally configure sources.jar for SDKs. * Update functions-ktx deps * Fix versions. * unbump fiam version in fiamui-app * Switch to use SharedPreferences from SQLite. * Change the cache class to be singleton * Copy firebase-firestore-ktx dependencies on firestore into its own subfolder (#528) * Wrap shared pref commit in a async task. * Address comments * Bump firestore version for release (#530) Additionally fix pom filter to exclude multidex from deps. * Google format fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effort replaces #494 by generating a list of artifacts instead of selectively publishing them. The
publishAllToBuildDirtask now produces an extra JSON file containing the names of all published artifacts. It also includes the artifacts that are affected by the most recent commit.Our compatibility testing infrastructure will be able to use this listing to build two variants of the tests: one against head and the other against the latest release (except for the affected artifacts).