-
Notifications
You must be signed in to change notification settings - Fork 615
Add Firebase Segmentation SDK and some skeleton code in Firebase Android SDK #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kindly ping |
.../androidTest/java/com/google/firebase/segmentation/FirebaseSegmentationInstrumentedTest.java
Outdated
Show resolved
Hide resolved
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. You might want to create PRs to merge from arete-floc to arete-floc-master and do one final PR to merge into master once ready.
firebase-segmentation/src/main/java/com/google/firebase/segmentation/FirebaseSegmentation.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to create PRs to merge from arete-floc to arete-floc-master and do one final PR to merge into master once ready.
Re mandar: merging this branch to floc-master, good point! |
/retest |
/retest |
No description provided.