Skip to content

Create M5CoreS3 pins_arduino.h and board #8161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2023
Merged

Create M5CoreS3 pins_arduino.h and board #8161

merged 2 commits into from
May 11, 2023

Conversation

Tinyu-Zhao
Copy link
Contributor

M5CoreS3 related documents

@Tinyu-Zhao Tinyu-Zhao mentioned this pull request May 4, 2023
Closed
@VojtechBartoska
Copy link
Contributor

VojtechBartoska commented May 5, 2023 •
edited
Loading

@Tinyu-Zhao PR doesn't passed CI Boards test.

Error:
"error: 'SS' was not declared in this scope"

You can check it here.

Please update your PR, thanks.

@VojtechBartoska VojtechBartoska added the Resolution: Awaiting response Waiting for response of author label May 5, 2023
@Tinyu-Zhao
Copy link
Contributor Author

Thanks for the reminder, but strangely I didn't find the pin definition of "ss" in the CoreS3 pin definition, but in AtomS3, now I have corrected it.

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes May 9, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tinyu-Zhao PTAL on the comments.

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this May 9, 2023
@Tinyu-Zhao
Copy link
Contributor Author

Thank your!

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels May 10, 2023
@me-no-dev me-no-dev merged commit 6075151 into espressif:master May 11, 2023
@tobozo
Copy link
Contributor

tobozo commented May 31, 2023

please don't merge this yet as there are still some issues:

  • the partition schemes list is incomplete, this unit has 16MB flash and the biggest partition listed is 8MB
  • the upload speed list is missing (it can be flashed at 1500000 bauds but 921600 is default selected and can't be changed)
  • PSRam can't be disabled

@P-R-O-C-H-Y
Copy link
Member

@tobozo As its already merged, please post a new PR with fixes for issues you mentioned. Thanks

@tobozo
Copy link
Contributor

tobozo commented May 31, 2023 •
edited
Loading

@P-R-O-C-H-Y sorry I got misled by the Status: Pending Merge label still attached to this post.

I'll submit a PR with the changes I've tested so far.

@Tinyu-Zhao is that acceptable to use the situation to introduce additional partition schemes?

image

image

This was referenced May 31, 2023
Closed
Merged
@bsergei bsergei mentioned this pull request Jun 6, 2023
Merged
tobozo added a commit to tobozo/arduino-esp32 that referenced this pull request Sep 11, 2023
@tobozo
M5CoreS3
395687f 
followup to espressif#8161 espressif#8274 espressif#8276
me-no-dev pushed a commit that referenced this pull request Sep 15, 2023
@tobozo
M5CoreS3 board and partitions update (#8276)
a6a287f 
* M5CoreS3

followup to #8161 #8274 #8276

* Add files via upload

* Fix partition names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tinyu-Zhao @VojtechBartoska @tobozo @P-R-O-C-H-Y @me-no-dev