M5CoreS3 board and partitions update

[tobozo]

followup to #8161

• adjusted default build values
  1. cdc default enabled
  2. 16MB flash + partition scheme copied from Core2 default selected
• added missing sections
• added two custom partitions schemes to the variant folder

the new custom partitions layout is open for discussions.

link to clean diff

[imliubo]

LGTM :)

[me-no-dev]

boards.txt change went wrong... shows 23k lines changed

[tobozo]

@me-no-dev it's just github being github :-) link to clean diff

[me-no-dev]

my 2 cents: if you require more than 2 OTA partitions, you are a very special case and should have the partition scheme in your sketch folder. Our code assumes 2 such partitions and does not allow for APP switching for example

[me-no-dev]

@me-no-dev it's just github being github :-) link to clean diff

maybe your editor changed some whitespaces? I do not think that github is at fault here

[tobozo]

The editor is github webapp, I edited the boards.txt from the browser and pasted the M5CoreS3 code block inside the existing flow. To my knowledge nothing else but the M5CoreS3 board block was modified in the file.

I've repeated the operation on the patch-6 branch but I can't edit the source branch for this PR, can someone with admin permissions do it, or should I close and submit a new PR from that branch?

[tobozo]

@me-no-dev thanks for your input!

if you require more than 2 OTA partitions, you are a very special case and should have the partition scheme in your sketch folder.

This is for a general use case and may eventually be extended to all M5Stack devices that come with 16MB flash and have an attached display.

Our code assumes 2 such partitions and does not allow for APP switching for example

It's still missing a custom bootloader to load the factory app on factory reset, but app switching is somehow possible with additional code.

So far it can boot from any of the app partitions (including the factory) provided there's some binary flashed there.

[tobozo]

resubmitted as #8276