Skip to content

ESPDuino boards change hardware #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

SmartArduino
Copy link

Update espduino.upload.resetmethod from ck to nodemcu, as we update the ESPDuino boards hardware.

Update espduino.upload.resetmethod from ck to nodemcu, as we update the ESPDuino boards hardware.
@codecov-io
Copy link

codecov-io commented Nov 12, 2016

Current coverage is 27.80% (diff: 100%)

Merging #2683 into master will not change coverage

@@             master      #2683   diff @@
==========================================
  Files            20         20          
  Lines          3625       3625          
  Methods         335        335          
  Messages          0          0          
  Branches        656        656          
==========================================
  Hits           1008       1008          
  Misses         2441       2441          
  Partials        176        176          

Powered by Codecov. Last update 7b32e6a...0dfc3ec

@WereCatf
Copy link
Contributor

Doing it like this would break support for the ESPduinos that are already out there. I would either list these new ones that use Nodemcu-reset as either a, separate revision or at least add a way of letting people select the reset-method:


generic.menu.ResetMethod.ck=ck
generic.menu.ResetMethod.ck.upload.resetmethod=ck
generic.menu.ResetMethod.nodemcu=nodemcu
generic.menu.ResetMethod.nodemcu.upload.resetmethod=nodemcu

@SmartArduino SmartArduino reopened this Dec 7, 2016
@d-a-v
Copy link
Collaborator

d-a-v commented Dec 11, 2017

@SmartArduino your ESPduino's changes are beeing incorporated into boards.txt.

But as @WereCatf had commented, why is the V1 using nodemcu as reset method, like V2 is (so there is no difference between the two) since it was using ck before ?

Is there a mistake in your boards.txt used as a reference for your board ?

I plan to revert V1 back to ck reset method for backward compatibility with previous boards.txt, and put V2 nodemcu by default in menu.

d-a-v added a commit to d-a-v/Arduino that referenced this pull request Dec 11, 2017
@devyte devyte closed this in #3940 Dec 12, 2017
devyte pushed a commit that referenced this pull request Dec 12, 2017
less confusing lwip versions in menus
fix #3850
fix #3707
fix #3640
fix #3098
fix #2740
fix #2683
fix #2550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants