-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add WeMos D1 Mini Pro to supported boards #2550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2550 +/- ##
======================================
Coverage 27.8% 27.8%
======================================
Files 20 20
Lines 3625 3625
Branches 656 656
======================================
Hits 1008 1008
Misses 2441 2441
Partials 176 176 Continue to review full report at Codecov.
|
@igrr my bruh! ;) When will be this merged? I really need it, it's already past more than one year from the Poll request! Just push that "Merge" button, just do it! Kappa |
@beicnet boards.txt will be generated by a script #3722. boards.txt in current master is already generated (but to be fixed). d1-mini-pro is already in the generator (not in master) so you can check if it is OK for you. The generator itself is to be merged after 2.4.0. |
@d-a-v Okay, the reason why I wanted that, it's because I don't wanna edit boards.txt file every time when new version is released or when I install a new Arduino session onto another computer (already using on 5 different computer), also I closed my PR #3098 because how I see, no one cares for it. Basically the ESPDuino board is useless at this time, because you can't change the board version from default v1 to v2... :( |
@beicnet I understand and I agree. In the meantime, instead of editing it you can just directly download it (link is in #3722 OP, I try to keep it updated on changes). I just pushed your relevant changes for ESPduino. BTW do you have both ESPDuino v1 and v2 ? I find it strange the |
@d-a-v Thank you so much for that!!! So, basically from now "ESPDuino and D1 Mini Pro" will be included in the boards.txt file? Another thing, @SmartArduino did a same PR as I did, see #2740 almost a year ago! Yes, I have a bunch of Wifi modules, also have D1 Mini Pro and ESPDuino too... And this is my ESPDuino listing from my current boards.txt and it's just working fine!
|
The generator will wait for 2.4.0 released (so in 2.4.x or in 2.5). Do you have both ESPduino-V1 and ESPDuino-V2 so you can check V1 too, because:
|
Dear @devyte Yes, I know that, but you know, it's easier to find your device in the "device list menu"! ;) |
less confusing lwip versions in menus fix esp8266#3850 fix esp8266#3707 fix esp8266#3640 fix esp8266#3098 fix esp8266#2740 fix esp8266#2683 fix esp8266#2550
What about the changes to: |
@mcauser Please reopen for these changes |
Please strip out all other changes and leave only the two md files. |
@mcauser Can you maybe add a few option for the SPIFFS to choose from?
|
@d-a-v Okay! 😉 |
conflict in boards.txt needs to be resolved, otherwise LGTM. |
@igrr sorry for the ping I clicked on the wrong button 😕 |
Closing here. D1 mini pro is there, though not reported to be fully tested / working. |
No description provided.