Update #1
Merged
Update #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `sudo npm i -g nativescript` is used, postinstall tasks produce errors, which confuse the users. CLI is actually installed successfully, but error for EACCESS is often shown. The problem is that npm executes the postinstall scripts with a special OS user - `nobody`. This user does not have permissions to write in users' directories, so generating html help or writing the user-settings.json file fails. Npm's solution is to pass `--unsafe-perm` to the `sudo npm install -g nativescript` command, which forces the postinstall to be executed with root user. Fix CLI's code to skip postinstall tasks in case sudo is used and `--unsafe-perm` is not passed.
…install fix: errors are shown on postinstall when using sudo
In case you have incorrect JAVA_HOME, but you have `javac` in PATH, CLI's doctor checks will allow you to build, but Gradle will fail. Fix the logic to be the same as the one used in Gradle.
…etection fix: detect java correctly
…roundAppQrCode method
…e is shown on device
feat(kinvey): provide correct data to preview-sdk based on the schema
fix: change ksplay to kspreview schema
fix(kinvey): use correct store ids for preview and scanner apps
# Conflicts: # package.json
chore: merge release into master
fix(grunt): generate unit testing dependencies on grunt rebuild command
fix: remove legacy code related to old structure of android project
In case 304 is returned, the cached version of the result should be used, so consider this response as success. NOTE: It can be returned only when specific header is sent in the request, so the caller actually expects to receive either 304 or 200 with new content.
fix: handle HTTP 304 response status code
fix: do not use HMR when debugBrk is set as we will restart the app on each LiveSync
Improve initialization service, so it can be used to initialize all settings required at the beginning of CLI process.
feat: improve logger
`--log trace` is broken as we are tring to iterate over object created with `Object.create(null)`. It uses the prototype of null, so it does not have `hasOwnProperty` method. Filter such objects from our checks in logger. Also nativescript-plugin-firebase uses logger.out, which has been deleted, get it back for backwards compatibility and delete it in 6.0.0 release.
fix: logger changes broke trace and some hooks
chore: set version to 6.0.0
style: misleading warning message
Several plugin use deleted logger methods in their hooks. Same is valid for `nativescript-cloud` extension. To resolve this, get back the deleted methods, we'll delete them in 6.0.0 release. Also, `nativescript-cloud` has an option `--workflow`, that is an object, while ours is boolean. This breaks its transpilation, so set ours to `any`.
…tible fix: make logger backwards compatible
chore: merge release in master
…ript-dev-xcode chore: update nativescript-dev-xcode to 0.2.0
fix: set correct link for legacy workflow warning
There are two new prompts in the plugin seed which require new command line options to be passed from CLI. Handle the new prompts and pass the new options. They can be used in automation scripts. In order to prevent such issue in the future, ensure the spawned process's stdout and stdin are inherited, so if there's a prompt in the plugin seed, CLI will show it to the user.
fix: plugin create command needs more args for plugin seed
docs: update changelog for 5.4.0 release
chore: merge release-patch in release
chore: merge release in master
…tion-vue-template feat: add vue drawer navigation template to create project command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].