fix: handle HTTP 304 response status code #4510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case 304 is returned, the cached version of the result should be used, so consider this response as success. NOTE: It can be returned only when specific header is sent in the request, so the caller actually expects to receive either 304 or 200 with new content.
ghost
added
the
Fatme
reviewed
Apr 8, 2019
| @@ -168,7 +168,7 @@ export class HttpClient implements Server.IHttpClient { | |||
| this.setResponseResult(promiseActions, cleanupRequestData, { err: new Error(HttpClient.STUCK_RESPONSE_ERROR_MESSAGE) }); | |||
| } | |||
| }, HttpClient.STUCK_RESPONSE_CHECK_INTERVAL); | |||
| const successful = helpers.isRequestSuccessful(responseData); | |||
| const successful = helpers.isRequestSuccessful(responseData) || responseData.statusCode === HttpStatusCodes.NOT_MODIFIED; | |||
There was a problem hiding this comment.
Maybe the check responseData.statusCode === HttpStatusCodes.NOT_MODIFIED should be inside isRequestSuccessful function
There was a problem hiding this comment.
I've considered this option, but I'm not sure if it is applicable for everyone who would use isRequestSuccessful helper method. By definition only requests between 200 and 300 are success, so it will seem strange to handle 304 inside that method
Fatme
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case 304 is returned, the cached version of the result should be used, so consider this response as success. NOTE: It can be returned only when specific header is sent in the request, so the caller actually expects to receive either 304 or 200 with new content.
PR Checklist
What is the current behavior?
Http requests returning 304 are considered as failed.
What is the new behavior?
Http requests returning 304 are considered as successful.
Fixes/Implements/Closes #[Issue Number].