Skip to content

fix: plugin create command needs more args for plugin seed #4614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2019

Conversation

rosen-vladimirov
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov commented May 13, 2019

There are two new prompts in the plugin seed which require new command line options to be passed from CLI. Handle the new prompts and pass the new options. They can be used in automation scripts.
In order to prevent such issue in the future, ensure the spawned process's stdout and stdin are inherited, so if there's a prompt in the plugin seed, CLI will show it to the user.

PR Checklist

What is the current behavior?

tns plugin create <pl name> command hangs.

What is the new behavior?

tns plugin create <pl name> command prompts for new params and can be automated with newly introduced command line flags.

Fixes issue #4616

There are two new prompts in the plugin seed which require new command line options to be passed from CLI. Handle the new prompts and pass the new options. They can be used in automation scripts.
In order to prevent such issue in the future, ensure the spawned process's stdout and stdin are inherited, so if there's a prompt in the plugin seed, CLI will show it to the user.
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/fix-plugin-create branch from 4453489 to 936cdff Compare May 13, 2019 14:50
@rosen-vladimirov rosen-vladimirov merged commit c3e16d6 into release May 13, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-plugin-create branch May 13, 2019 15:04
@ghost ghost removed the new PR label May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants